diff options
| author | rdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-05 16:16:30 +0000 |
|---|---|---|
| committer | rdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-05 16:16:30 +0000 |
| commit | d695bb139a93f2c0cab08b1801c2cddba1a39773 (patch) | |
| tree | b6ee5cfc101d0506d87200f0b09d6189754834ff /chrome/browser/extensions/extension_tab_util.cc | |
| parent | 32e8a26ae2917d695551f1e37701e0eff52879de (diff) | |
| download | chromium_src-d695bb139a93f2c0cab08b1801c2cddba1a39773.zip chromium_src-d695bb139a93f2c0cab08b1801c2cddba1a39773.tar.gz chromium_src-d695bb139a93f2c0cab08b1801c2cddba1a39773.tar.bz2 | |
Refactor PermissionsData pt1
In this CL, we:
- Make PermissionsData not-so-static. Only methods which either don't rely on
knowledge of specific permissions or methods to get/create the object are
static.
- Separate runtime permissions knowledge from manifest parsing (PermissionsData
vs PermissionsParser)
- Move required/optional permissions access into PermissionsParser.
- Handle the locking issues.
BUG=379356
TBR=sky@chromium.org (for c/b/ui/, no functional changes)
Review URL: https://codereview.chromium.org/309533007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275142 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_tab_util.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_tab_util.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc index 39b5f35..b0177e1 100644 --- a/chrome/browser/extensions/extension_tab_util.cc +++ b/chrome/browser/extensions/extension_tab_util.cc @@ -391,8 +391,8 @@ void ExtensionTabUtil::ScrubTabValueForExtension( base::DictionaryValue* tab_info) { bool has_permission = extension && - PermissionsData::HasAPIPermissionForTab( - extension, GetTabId(contents), APIPermission::kTab); + PermissionsData::ForExtension(extension) + ->HasAPIPermissionForTab(GetTabId(contents), APIPermission::kTab); if (!has_permission) { tab_info->Remove(keys::kUrlKey, NULL); |