diff options
author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-25 09:08:19 +0000 |
---|---|---|
committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-25 09:08:19 +0000 |
commit | 3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19 (patch) | |
tree | b26f7f81e48a95473eb4af5304301e9d8cd22fb8 /chrome/browser/extensions/extension_test_api.h | |
parent | eef99b6591d82399096abdcee07dd67359eec036 (diff) | |
download | chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.zip chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.tar.gz chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.tar.bz2 |
Virtual destructors should have virtual keyword.
Make sure user-declared virtual destructors always have the virtual keyword.
The Clang style-check plugin will check for this soon.
No functionality change: virtual is only added
to destructors that are already implicitly virtual.
Also fix a couple of in-line destructor definitions.
BUG=83408
TEST=none
Review URL: http://codereview.chromium.org/7064033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_test_api.h')
-rw-r--r-- | chrome/browser/extensions/extension_test_api.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/chrome/browser/extensions/extension_test_api.h b/chrome/browser/extensions/extension_test_api.h index 1a0baa0..b3c113a 100644 --- a/chrome/browser/extensions/extension_test_api.h +++ b/chrome/browser/extensions/extension_test_api.h @@ -12,31 +12,31 @@ template <typename T> struct DefaultSingletonTraits; class ExtensionTestPassFunction : public SyncExtensionFunction { - ~ExtensionTestPassFunction(); + virtual ~ExtensionTestPassFunction(); virtual bool RunImpl(); DECLARE_EXTENSION_FUNCTION_NAME("test.notifyPass") }; class ExtensionTestFailFunction : public SyncExtensionFunction { - ~ExtensionTestFailFunction(); + virtual ~ExtensionTestFailFunction(); virtual bool RunImpl(); DECLARE_EXTENSION_FUNCTION_NAME("test.notifyFail") }; class ExtensionTestLogFunction : public SyncExtensionFunction { - ~ExtensionTestLogFunction(); + virtual ~ExtensionTestLogFunction(); virtual bool RunImpl(); DECLARE_EXTENSION_FUNCTION_NAME("test.log") }; class ExtensionTestQuotaResetFunction : public SyncExtensionFunction { - ~ExtensionTestQuotaResetFunction(); + virtual ~ExtensionTestQuotaResetFunction(); virtual bool RunImpl(); DECLARE_EXTENSION_FUNCTION_NAME("test.resetQuota") }; class ExtensionTestCreateIncognitoTabFunction : public SyncExtensionFunction { - ~ExtensionTestCreateIncognitoTabFunction(); + virtual ~ExtensionTestCreateIncognitoTabFunction(); virtual bool RunImpl(); DECLARE_EXTENSION_FUNCTION_NAME("test.createIncognitoTab") }; @@ -48,7 +48,7 @@ class ExtensionTestSendMessageFunction : public AsyncExtensionFunction { void Reply(const std::string& message); private: - ~ExtensionTestSendMessageFunction(); + virtual ~ExtensionTestSendMessageFunction(); virtual bool RunImpl(); DECLARE_EXTENSION_FUNCTION_NAME("test.sendMessage") }; @@ -81,7 +81,7 @@ class ExtensionTestGetConfigFunction : public SyncExtensionFunction { DISALLOW_COPY_AND_ASSIGN(TestConfigState); }; - ~ExtensionTestGetConfigFunction(); + virtual ~ExtensionTestGetConfigFunction(); virtual bool RunImpl(); DECLARE_EXTENSION_FUNCTION_NAME("test.getConfig") }; |