diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-27 20:28:42 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-27 20:28:42 +0000 |
| commit | 0211f57eabdc1a3e34aee1e1629c26e93b803ded (patch) | |
| tree | 3bcbab3506e5f3dbcbc99825529cc803d223b017 /chrome/browser/extensions/extension_updater.cc | |
| parent | 1f8322043d302eb0f6a050a21d2f0f9a8c1df71e (diff) | |
| download | chromium_src-0211f57eabdc1a3e34aee1e1629c26e93b803ded.zip chromium_src-0211f57eabdc1a3e34aee1e1629c26e93b803ded.tar.gz chromium_src-0211f57eabdc1a3e34aee1e1629c26e93b803ded.tar.bz2 | |
Refactor version-getting info into a chrome::VersionInfo object.
I was trying to replace wstring usage in base::FileVersionInfo, but
that class is rather Windows-specific with strange fields like
"private_build()" where the value and encoding aren't clear. 95%
of the users of FileVersionInfo actually just care about the current
Chrome version, so we can provide a much simpler interface for them.
We still use FileVersionInfo for retrieving information from e.g.
plugin DLLs, but in those cases the usage is clearer.
Review URL: http://codereview.chromium.org/3135028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_updater.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_updater.cc | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/chrome/browser/extensions/extension_updater.cc b/chrome/browser/extensions/extension_updater.cc index 99415b4..2e1b867 100644 --- a/chrome/browser/extensions/extension_updater.cc +++ b/chrome/browser/extensions/extension_updater.cc @@ -9,7 +9,6 @@ #include "base/logging.h" #include "base/file_util.h" -#include "base/file_version_info.h" #include "base/histogram.h" #include "base/rand_util.h" #include "base/sha2.h" @@ -768,11 +767,10 @@ std::vector<int> ExtensionUpdater::DetermineUpdates( if (update->browser_min_version.length() > 0) { // First determine the browser version if we haven't already. if (!browser_version.get()) { - scoped_ptr<FileVersionInfo> version_info( - chrome::GetChromeVersionInfo()); - if (version_info.get()) { + chrome::VersionInfo version_info; + if (version_info.is_valid()) { browser_version.reset(Version::GetVersionFromString( - version_info->product_version())); + version_info.Version())); } } scoped_ptr<Version> browser_min_version( |