summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extensions_service.h
diff options
context:
space:
mode:
authoraa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-27 17:19:18 +0000
committeraa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-27 17:19:18 +0000
commitbb28e069474790ba5d46e07bb54412649a04c536 (patch)
tree9fc53b4a324fa2a214c8bd0e77e0ff11afb96d71 /chrome/browser/extensions/extensions_service.h
parent2d268b537e9f420f952c22a0faeb6c52d047f463 (diff)
downloadchromium_src-bb28e069474790ba5d46e07bb54412649a04c536.zip
chromium_src-bb28e069474790ba5d46e07bb54412649a04c536.tar.gz
chromium_src-bb28e069474790ba5d46e07bb54412649a04c536.tar.bz2
Add a centralized error reporter to the
extensions sytem. This can be called from any component on any thread. The hope is that this will encourage more thorough error handling. Review URL: http://codereview.chromium.org/27165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10611 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extensions_service.h')
-rw-r--r--chrome/browser/extensions/extensions_service.h16
1 files changed, 2 insertions, 14 deletions
diff --git a/chrome/browser/extensions/extensions_service.h b/chrome/browser/extensions/extensions_service.h
index c8f04b0..efba0086 100644
--- a/chrome/browser/extensions/extensions_service.h
+++ b/chrome/browser/extensions/extensions_service.h
@@ -37,18 +37,10 @@ class ExtensionsServiceFrontendInterface
// Load the extension from the directory |extension_path|.
virtual void LoadExtension(const FilePath& extension_path) = 0;
- // Called when loading an extension fails.
- virtual void OnExtensionLoadError(bool alert_on_error,
- const std::string& message) = 0;
-
// Called with results from LoadExtensionsFromDirectory(). The frontend
// takes ownership of the list.
virtual void OnExtensionsLoadedFromDirectory(ExtensionList* extensions) = 0;
- // Called when installing an extension fails.
- virtual void OnExtensionInstallError(bool alert_on_error,
- const std::string& message) = 0;
-
// Called with results from InstallExtension().
// |is_update| is true if the installation was an update to an existing
// installed extension rather than a new installation.
@@ -75,11 +67,7 @@ class ExtensionsService : public ExtensionsServiceFrontendInterface {
virtual MessageLoop* GetMessageLoop();
virtual void InstallExtension(const FilePath& extension_path);
virtual void LoadExtension(const FilePath& extension_path);
- virtual void OnExtensionLoadError(bool alert_on_error,
- const std::string& message);
virtual void OnExtensionsLoadedFromDirectory(ExtensionList* extensions);
- virtual void OnExtensionInstallError(bool alert_on_error,
- const std::string& message);
virtual void OnExtensionInstalled(FilePath path, bool is_update);
// The name of the file that the current active version number is stored in.
@@ -118,7 +106,7 @@ class ExtensionsServiceBackend
// Loads extensions from a directory. The extensions are assumed to be
// unpacked in directories that are direct children of the specified path.
- // Errors are reported through OnExtensionLoadError(). On completion,
+ // Errors are reported through ExtensionErrorReporter. On completion,
// OnExtensionsLoadedFromDirectory() is called with any successfully loaded
// extensions.
void LoadExtensionsFromDirectory(
@@ -127,7 +115,7 @@ class ExtensionsServiceBackend
// Loads a single extension from |path| where |path| is the top directory of
// a specific extension where its manifest file lives.
- // Errors are reported through OnExtensionLoadError(). On completion,
+ // Errors are reported through ExtensionErrorReporter. On completion,
// OnExtensionsLoadedFromDirectory() is called with any successfully loaded
// extensions.
// TODO(erikkay): It might be useful to be able to load a packed extension