Loads local resources from current locale subtree if available, if not it falls back to extension subtree.

We look for ext_root/foo/bar.js under ext_root/_locales/fr/foo/bar.js if current locale is fr. If there is no fr specific resource we load ext_root/foo/bar.js instead.

Lots of small refactoring to replace FilePath with ExtensionResource.


BUG=12131
TEST=See unittest for sample tree.


Review URL: http://codereview.chromium.org/256022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28333 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 97 insertions, 0 deletions

diff --git a/chrome/browser/extensions/file_reader_unittest.cc b/chrome/browser/extensions/file_reader_unittest.cc
new file mode 100644
index 0000000..bf16b71
--- /dev/null
+++ b/chrome/browser/extensions/file_reader_unittest.cc
@@ -0,0 +1,97 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/message_loop.h"
+#include "base/path_service.h"
+#include "chrome/browser/chrome_thread.h"
+#include "chrome/browser/extensions/file_reader.h"
+#include "chrome/common/chrome_paths.h"
+#include "chrome/common/extensions/extension_resource.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+class FileReaderTest : public testing::Test {
+ public:
+  FileReaderTest() : file_thread_(ChromeThread::FILE) {
+    file_thread_.Start();
+  }
+ private:
+  MessageLoop message_loop_;
+  ChromeThread file_thread_;
+};
+
+class Receiver {
+ public:
+  Receiver() : succeeded_(false) {
+  }
+
+  FileReader::Callback* NewCallback() {
+    return ::NewCallback(this, &Receiver::DidReadFile);
+  }
+
+  bool succeeded() const { return succeeded_; }
+  const std::string& data() const { return data_; }
+
+ private:
+  void DidReadFile(bool success, const std::string& data) {
+    succeeded_ = success;
+    data_ = data;
+    MessageLoop::current()->Quit();
+  }
+
+  bool succeeded_;
+  std::string data_;
+};
+
+void RunBasicTest(const char* filename) {
+  FilePath path;
+  PathService::Get(chrome::DIR_TEST_DATA, &path);
+  ExtensionResource resource(path, FilePath().AppendASCII(filename));
+  path = path.AppendASCII(filename);
+
+  std::string file_contents;
+  bool file_exists = file_util::ReadFileToString(path, &file_contents);
+
+  Receiver receiver;
+
+  scoped_refptr<FileReader> file_reader(
+      new FileReader(resource, receiver.NewCallback()));
+  file_reader->Start();
+
+  MessageLoop::current()->Run();
+
+  EXPECT_EQ(file_exists, receiver.succeeded());
+  EXPECT_EQ(file_contents, receiver.data());
+}
+
+TEST_F(FileReaderTest, SmallFile) {
+  RunBasicTest("title1.html");
+}
+
+TEST_F(FileReaderTest, BiggerFile) {
+  RunBasicTest("download-test1.lib");
+}
+
+TEST_F(FileReaderTest, NonExistantFile) {
+  FilePath path;
+  PathService::Get(chrome::DIR_TEST_DATA, &path);
+  ExtensionResource resource(path, FilePath(
+      FILE_PATH_LITERAL("file_that_does_not_exist")));
+  path = path.AppendASCII("file_that_does_not_exist");
+
+  Receiver receiver;
+
+  scoped_refptr<FileReader> file_reader(
+      new FileReader(resource, receiver.NewCallback()));
+  file_reader->Start();
+
+  MessageLoop::current()->Run();
+
+  EXPECT_FALSE(receiver.succeeded());
+}
+
+}  // namespace