diff options
| author | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-20 16:18:21 +0000 |
|---|---|---|
| committer | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-20 16:18:21 +0000 |
| commit | dbb92e0d55eede17bf2ada8370650d39834e6060 (patch) | |
| tree | 941532e52eceab1115b60556960abde35f786368 /chrome/browser/extensions/sandboxed_extension_unpacker.cc | |
| parent | e667f718463a78b7d1de5a51e71982211f00f875 (diff) | |
| download | chromium_src-dbb92e0d55eede17bf2ada8370650d39834e6060.zip chromium_src-dbb92e0d55eede17bf2ada8370650d39834e6060.tar.gz chromium_src-dbb92e0d55eede17bf2ada8370650d39834e6060.tar.bz2 | |
Do extensions update manifest XML parsing in a sandboxed process.
This involves moving the xml parsing code from static functions in
extension_updater.cc to a UpdateManifest class, and switching from
logging any errors directly to collecting them up and passing them
across the IPC channel.
BUG=http://crbug.com/12677
TEST=extensions auto-update should still work correctly
Review URL: http://codereview.chromium.org/164541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23822 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/sandboxed_extension_unpacker.cc')
| -rw-r--r-- | chrome/browser/extensions/sandboxed_extension_unpacker.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker.cc b/chrome/browser/extensions/sandboxed_extension_unpacker.cc index 7f6e5ae..e1d600c 100644 --- a/chrome/browser/extensions/sandboxed_extension_unpacker.cc +++ b/chrome/browser/extensions/sandboxed_extension_unpacker.cc @@ -60,6 +60,9 @@ void SandboxedExtensionUnpacker::Start() { // If we are supposed to use a subprocess, copy the crx to the temp directory // and kick off the subprocess. + // + // TODO(asargent) we shouldn't need to do this branch here - instead + // UtilityProcessHost should handle it for us. (http://crbug.com/19192) if (rdh_ && !CommandLine::ForCurrentProcess()->HasSwitch(switches::kSingleProcess)) { ChromeThread::GetMessageLoop(ChromeThread::IO)->PostTask(FROM_HERE, |