diff options
| author | rdevlin.cronin <rdevlin.cronin@chromium.org> | 2015-09-24 12:50:55 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-24 19:52:04 +0000 |
| commit | cce78d017ca073f0719a8967e29c68f3553cbf4a (patch) | |
| tree | b043cba86b44197a02f50a6f77fd78407044df2b /chrome/browser/extensions/settings_api_bubble_controller.h | |
| parent | 1748d384c547136d059d413f5acbb1622ba548f0 (diff) | |
| download | chromium_src-cce78d017ca073f0719a8967e29c68f3553cbf4a.zip chromium_src-cce78d017ca073f0719a8967e29c68f3553cbf4a.tar.gz chromium_src-cce78d017ca073f0719a8967e29c68f3553cbf4a.tar.bz2 | |
[Extensions] Fix race condition crashes in the extension bubbles
There were race conditions due to the asynchronous display of extension bubbles
where the extension(s) could have been uninstalled before the bubble is
displayed (it seems the most common time these happen is when an extension to be
warned about is queued for uninstallation via sync). Handle this situation
gracefully.
BUG=531648
TBR=sky@chromium.org (micro ui changes in files that aren't explicitly owned by finnur@)
Review URL: https://codereview.chromium.org/1352103003
Cr-Commit-Position: refs/heads/master@{#350627}
Diffstat (limited to 'chrome/browser/extensions/settings_api_bubble_controller.h')
| -rw-r--r-- | chrome/browser/extensions/settings_api_bubble_controller.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/chrome/browser/extensions/settings_api_bubble_controller.h b/chrome/browser/extensions/settings_api_bubble_controller.h index 6daf755..0e1c620 100644 --- a/chrome/browser/extensions/settings_api_bubble_controller.h +++ b/chrome/browser/extensions/settings_api_bubble_controller.h @@ -19,10 +19,6 @@ class SettingsApiBubbleController : public ExtensionMessageBubbleController { SettingsApiBubbleController(Browser* browser, SettingsApiOverrideType type); ~SettingsApiBubbleController() override; - // Returns true if we should show the bubble for the extension actively - // overriding the setting of |type_|. - bool ShouldShow(); - // ExtensionMessageBubbleController: bool CloseOnDeactivate() override; |