diff options
| author | rdevlin.cronin <rdevlin.cronin@chromium.org> | 2015-11-20 09:20:35 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-20 17:21:08 +0000 |
| commit | 486b20e71bb481cf6ae6491a998aa252081a8833 (patch) | |
| tree | 35d1d0ff76938b895d5129159db9fcc47d1f10e4 /chrome/browser/extensions/settings_api_bubble_delegate.h | |
| parent | 4dee2a9aaab948a2603c88be06e3de528bdb35bd (diff) | |
| download | chromium_src-486b20e71bb481cf6ae6491a998aa252081a8833.zip chromium_src-486b20e71bb481cf6ae6491a998aa252081a8833.tar.gz chromium_src-486b20e71bb481cf6ae6491a998aa252081a8833.tar.bz2 | |
[Reland][Extensions] Don't count bubble focus loss as acknowledgment
Currently, if an extension message bubble is shown, and then it is dismissed
because it loses focus, we treat it the same as the user clicking the dismiss
button - which serves as acknowledging the extension. We could ignore focus
loss, but this makes for very noisy, awkward bubbles. Instead, allow the bubble
to close, but don't treat this as user acknowledgment, and show the bubble again
on next startup.
This also involves tracking the close reason for a BubbleDelegateView.
BUG=548269
TBR=finnur@chromium.org (no changes relevant from original CL)
TBR=avi@chromium.org (no changes relevant from original CL)
Review URL: https://codereview.chromium.org/1455313002
Cr-Commit-Position: refs/heads/master@{#360848}
Diffstat (limited to 'chrome/browser/extensions/settings_api_bubble_delegate.h')
| -rw-r--r-- | chrome/browser/extensions/settings_api_bubble_delegate.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/extensions/settings_api_bubble_delegate.h b/chrome/browser/extensions/settings_api_bubble_delegate.h index dde081d..aea8350 100644 --- a/chrome/browser/extensions/settings_api_bubble_delegate.h +++ b/chrome/browser/extensions/settings_api_bubble_delegate.h @@ -39,6 +39,7 @@ class SettingsApiBubbleDelegate bool ShouldLimitToEnabledExtensions() const override; void LogExtensionCount(size_t count) override; void LogAction(ExtensionMessageBubbleController::BubbleAction) override; + const char* GetKey() override; private: // The type of settings override this bubble will report on. This can be, for |