Add a commandline flag to chrome to validate crx files

BUG=222215


Review URL: https://chromiumcodereview.appspot.com/12660017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191186 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 63 insertions, 0 deletions

diff --git a/chrome/browser/extensions/startup_helper_browsertest.cc b/chrome/browser/extensions/startup_helper_browsertest.cc
new file mode 100644
index 0000000..4d1d129
--- /dev/null
+++ b/chrome/browser/extensions/startup_helper_browsertest.cc
@@ -0,0 +1,63 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <vector>
+
+#include "base/command_line.h"
+#include "base/files/file_path.h"
+#include "base/path_service.h"
+#include "chrome/browser/extensions/startup_helper.h"
+#include "chrome/common/chrome_paths.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/test/base/in_process_browser_test.h"
+
+class StartupHelperBrowserTest : public InProcessBrowserTest {
+ public:
+  StartupHelperBrowserTest() {}
+  virtual ~StartupHelperBrowserTest() {}
+
+  virtual void SetUpCommandLine(CommandLine* command_line) {
+    command_line->AppendSwitch(switches::kNoStartupWindow);
+    PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir_);
+    test_data_dir_ = test_data_dir_.AppendASCII("extensions");
+  }
+
+ protected:
+  base::FilePath test_data_dir_;
+};
+
+IN_PROC_BROWSER_TEST_F(StartupHelperBrowserTest, ValidateCrx) {
+  // A list of crx file paths along with an expected result of valid (true) or
+  // invalid (false).
+  std::vector<std::pair<base::FilePath, bool> > expectations;
+  expectations.push_back(
+      std::make_pair(test_data_dir_.AppendASCII("good.crx"), true));
+  expectations.push_back(
+      std::make_pair(test_data_dir_.AppendASCII("good2.crx"), true));
+  expectations.push_back(
+      std::make_pair(test_data_dir_.AppendASCII("bad_magic.crx"), false));
+  expectations.push_back(
+      std::make_pair(test_data_dir_.AppendASCII("bad_underscore.crx"), false));
+
+  for (std::vector<std::pair<base::FilePath, bool> >::iterator i =
+           expectations.begin();
+       i != expectations.end(); ++i) {
+    CommandLine command_line(CommandLine::NO_PROGRAM);
+    const base::FilePath& path = i->first;
+    command_line.AppendSwitchPath(switches::kValidateCrx, path);
+
+    std::string error;
+    extensions::StartupHelper helper;
+    bool result = helper.ValidateCrx(command_line, &error);
+    if (i->second) {
+      EXPECT_TRUE(result) << path.LossyDisplayName()
+                          << " expected to be valid but wasn't";
+    } else {
+      EXPECT_FALSE(result) << path.LossyDisplayName()
+                           << " expected to be invalid but wasn't";
+      EXPECT_FALSE(error.empty()) << "Error message wasn't set for "
+                                  << path.LossyDisplayName();
+    }
+  }
+}