summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/suspicious_extension_bubble_controller.cc
diff options
context:
space:
mode:
authorrdevlin.cronin <rdevlin.cronin@chromium.org>2015-04-15 10:49:06 -0700
committerCommit bot <commit-bot@chromium.org>2015-04-15 17:49:38 +0000
commit70fc60535fb99318170676856ecf1044ba083f68 (patch)
tree2cb6361dba604c4bea23d7eb078810c319fad310 /chrome/browser/extensions/suspicious_extension_bubble_controller.cc
parent97178058a1ab20f88d55a641d8d07e875aa504f0 (diff)
downloadchromium_src-70fc60535fb99318170676856ecf1044ba083f68.zip
chromium_src-70fc60535fb99318170676856ecf1044ba083f68.tar.gz
chromium_src-70fc60535fb99318170676856ecf1044ba083f68.tar.bz2
[Reland] [Extensions] Make extension message bubble factory platform-abstract
We want to show extension message bubbles on multiple platforms; the first step towards this is to make the bubble factory platform-abstract. Do so, and also add a handful of tests for the process of showing the bubble. BUG=474092 TBR=sky@chromium.org (no relevant changes since original land) Review URL: https://codereview.chromium.org/1087713002 Cr-Commit-Position: refs/heads/master@{#325269}
Diffstat (limited to 'chrome/browser/extensions/suspicious_extension_bubble_controller.cc')
-rw-r--r--chrome/browser/extensions/suspicious_extension_bubble_controller.cc8
1 files changed, 6 insertions, 2 deletions
diff --git a/chrome/browser/extensions/suspicious_extension_bubble_controller.cc b/chrome/browser/extensions/suspicious_extension_bubble_controller.cc
index da364b2..94d189f 100644
--- a/chrome/browser/extensions/suspicious_extension_bubble_controller.cc
+++ b/chrome/browser/extensions/suspicious_extension_bubble_controller.cc
@@ -53,6 +53,7 @@ class SuspiciousExtensionBubbleDelegate
base::string16 GetActionButtonLabel() const override;
base::string16 GetDismissButtonLabel() const override;
bool ShouldShowExtensionList() const override;
+ bool ShouldHighlightExtensions() const override;
void LogExtensionCount(size_t count) override;
void LogAction(
ExtensionMessageBubbleController::BubbleAction action) override;
@@ -126,11 +127,14 @@ SuspiciousExtensionBubbleDelegate::GetDismissButtonLabel() const {
return l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNSUPPORTED_DISABLED_BUTTON);
}
-bool
-SuspiciousExtensionBubbleDelegate::ShouldShowExtensionList() const {
+bool SuspiciousExtensionBubbleDelegate::ShouldShowExtensionList() const {
return true;
}
+bool SuspiciousExtensionBubbleDelegate::ShouldHighlightExtensions() const {
+ return false;
+}
+
void SuspiciousExtensionBubbleDelegate::LogExtensionCount(
size_t count) {
UMA_HISTOGRAM_COUNTS_100(