diff options
| author | rdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-17 18:50:01 +0000 |
|---|---|---|
| committer | rdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-17 18:50:01 +0000 |
| commit | d382baa5eb8e2c1a7b86101844bb42b68d936ac0 (patch) | |
| tree | 4c503b725b80ae8b198cc0dd326b631462d41cd8 /chrome/browser/extensions/webstore_startup_installer.h | |
| parent | 9e3074b4fc36b51906c94592703e6733058ae92d (diff) | |
| download | chromium_src-d382baa5eb8e2c1a7b86101844bb42b68d936ac0.zip chromium_src-d382baa5eb8e2c1a7b86101844bb42b68d936ac0.tar.gz chromium_src-d382baa5eb8e2c1a7b86101844bb42b68d936ac0.tar.bz2 | |
Make ExtensionInstallPrompt::Prompt ref-counted
We pass around ExtensionInstallPrompt::Prompt a lot by value and reference,
but should probably just have it ref-counted instead. It's an expensive
object to copy (which we do far too much right now), and passing around
weak references is dangerous (and leads to crashing).
TBR=ben@chromium.org (c/b/ui minus c/b/ui/cocoa)
TBR=kinaba@chromium.org (c/b/chromeos/file_manager)
TBR=koz@chromium.org (c/b/apps)
All TBRs are for strictly mechanical changes.
Review URL: https://codereview.chromium.org/313203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277823 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/webstore_startup_installer.h')
| -rw-r--r-- | chrome/browser/extensions/webstore_startup_installer.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/extensions/webstore_startup_installer.h b/chrome/browser/extensions/webstore_startup_installer.h index de6cb6e..b90eba6 100644 --- a/chrome/browser/extensions/webstore_startup_installer.h +++ b/chrome/browser/extensions/webstore_startup_installer.h @@ -30,8 +30,8 @@ class WebstoreStartupInstaller : public WebstoreInstallWithPrompt { virtual ~WebstoreStartupInstaller(); // Implementations of WebstoreStandaloneInstaller Template Method's hooks. - virtual scoped_ptr<ExtensionInstallPrompt::Prompt> - CreateInstallPrompt() const OVERRIDE; + virtual scoped_refptr<ExtensionInstallPrompt::Prompt> CreateInstallPrompt() + const OVERRIDE; private: bool show_prompt_; |