diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-13 19:56:17 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-13 19:56:17 +0000 |
commit | 11f48572859aca238afeb436d2504c5ffab49f07 (patch) | |
tree | 1b31af349eb99a9e83716f5add3273b42bee41cf /chrome/browser/extensions | |
parent | af530ac147feb1b04446f529daa4cc4448f89b23 (diff) | |
download | chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.zip chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.tar.gz chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.tar.bz2 |
Fixes almost all of the rest of lint errors in the chrome/ directory (minus the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
9 files changed, 18 insertions, 18 deletions
diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h index 21de58d..48a7d58 100644 --- a/chrome/browser/extensions/crx_installer.h +++ b/chrome/browser/extensions/crx_installer.h @@ -34,9 +34,9 @@ class SkBitmap; // long enough to receive the result of unpacking. // // TODO(aa): Pull out a frontend interface for testing? -class CrxInstaller : - public SandboxedExtensionUnpackerClient, - public ExtensionInstallUI::Delegate { +class CrxInstaller + : public SandboxedExtensionUnpackerClient, + public ExtensionInstallUI::Delegate { public: // Starts the installation of the crx file in |source_file| into // |install_directory|. diff --git a/chrome/browser/extensions/extension_function_dispatcher.h b/chrome/browser/extensions/extension_function_dispatcher.h index 16a9fb3..d9c0ea5 100644 --- a/chrome/browser/extensions/extension_function_dispatcher.h +++ b/chrome/browser/extensions/extension_function_dispatcher.h @@ -39,7 +39,8 @@ class ExtensionFunctionDispatcher { // destroyed. // TODO: this should use WeakPtr struct Peer : public base::RefCounted<Peer> { - Peer(ExtensionFunctionDispatcher* dispatcher) : dispatcher_(dispatcher) {} + explicit Peer(ExtensionFunctionDispatcher* dispatcher) + : dispatcher_(dispatcher) {} ExtensionFunctionDispatcher* dispatcher_; private: diff --git a/chrome/browser/extensions/extension_shelf_model.h b/chrome/browser/extensions/extension_shelf_model.h index 29f6592..bffdbdf 100644 --- a/chrome/browser/extensions/extension_shelf_model.h +++ b/chrome/browser/extensions/extension_shelf_model.h @@ -24,7 +24,7 @@ class ExtensionShelfModelObserver; // are specific to a Browser. class ExtensionShelfModel : public NotificationObserver { public: - ExtensionShelfModel(Browser* browser); + explicit ExtensionShelfModel(Browser* browser); virtual ~ExtensionShelfModel(); struct ToolstripItem { diff --git a/chrome/browser/extensions/extensions_service.h b/chrome/browser/extensions/extensions_service.h index 2393891..1a8c336 100644 --- a/chrome/browser/extensions/extensions_service.h +++ b/chrome/browser/extensions/extensions_service.h @@ -309,7 +309,7 @@ class ExtensionsServiceBackend // |rdh| can be NULL in the case of test environment. // |extension_prefs| contains a dictionary value that points to the extension // preferences. - ExtensionsServiceBackend(const FilePath& install_directory); + explicit ExtensionsServiceBackend(const FilePath& install_directory); // Loads a single extension from |path| where |path| is the top directory of // a specific extension where its manifest file lives. diff --git a/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h b/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h index 2d72403..abb66b5 100644 --- a/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h +++ b/chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_VIEWS_EXTENSIONS_GTK_THEME_INSTALLED_INFOBAR_DELEGATE_H_ -#define CHROME_BROWSER_VIEWS_EXTENSIONS_GTK_THEME_INSTALLED_INFOBAR_DELEGATE_H_ +#ifndef CHROME_BROWSER_EXTENSIONS_GTK_THEME_INSTALLED_INFOBAR_DELEGATE_H_ +#define CHROME_BROWSER_EXTENSIONS_GTK_THEME_INSTALLED_INFOBAR_DELEGATE_H_ #include "chrome/browser/extensions/theme_installed_infobar_delegate.h" @@ -27,4 +27,4 @@ class GtkThemeInstalledInfoBarDelegate : public ThemeInstalledInfoBarDelegate { bool previous_use_gtk_theme_; }; -#endif // CHROME_BROWSER_VIEWS_EXTENSIONS_GTK_THEME_INSTALLED_INFOBAR_DELEGATE_H_ +#endif // CHROME_BROWSER_EXTENSIONS_GTK_THEME_INSTALLED_INFOBAR_DELEGATE_H_ diff --git a/chrome/browser/extensions/pack_extension_job.h b/chrome/browser/extensions/pack_extension_job.h index 526d16d..8c008d9 100644 --- a/chrome/browser/extensions/pack_extension_job.h +++ b/chrome/browser/extensions/pack_extension_job.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_EXTENSIONS_PACK_EXTENSION_JOB_UI_H_ -#define CHROME_BROWSER_EXTENSIONS_PACK_EXTENSION_JOB_UI_H_ +#ifndef CHROME_BROWSER_EXTENSIONS_PACK_EXTENSION_JOB_H_ +#define CHROME_BROWSER_EXTENSIONS_PACK_EXTENSION_JOB_H_ #include <string> @@ -52,5 +52,4 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> { DISALLOW_COPY_AND_ASSIGN(PackExtensionJob); }; -#endif // CHROME_BROWSER_EXTENSIONS_PACK_EXTENSION_JOB_UI_H_ - +#endif // CHROME_BROWSER_EXTENSIONS_PACK_EXTENSION_JOB_H_ diff --git a/chrome/browser/extensions/theme_installed_infobar_delegate.h b/chrome/browser/extensions/theme_installed_infobar_delegate.h index 90c25a5..daa11e6 100644 --- a/chrome/browser/extensions/theme_installed_infobar_delegate.h +++ b/chrome/browser/extensions/theme_installed_infobar_delegate.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_VIEWS_EXTENSIONS_THEME_INSTALLED_INFOBAR_DELEGATE_H_ -#define CHROME_BROWSER_VIEWS_EXTENSIONS_THEME_INSTALLED_INFOBAR_DELEGATE_H_ +#ifndef CHROME_BROWSER_EXTENSIONS_THEME_INSTALLED_INFOBAR_DELEGATE_H_ +#define CHROME_BROWSER_EXTENSIONS_THEME_INSTALLED_INFOBAR_DELEGATE_H_ #include "chrome/browser/tab_contents/infobar_delegate.h" @@ -43,4 +43,4 @@ class ThemeInstalledInfoBarDelegate : public ConfirmInfoBarDelegate { std::string previous_theme_id_; }; -#endif // CHROME_BROWSER_VIEWS_EXTENSIONS_THEME_INSTALLED_INFOBAR_DELEGATE_H_ +#endif // CHROME_BROWSER_EXTENSIONS_THEME_INSTALLED_INFOBAR_DELEGATE_H_ diff --git a/chrome/browser/extensions/user_script_listener.h b/chrome/browser/extensions/user_script_listener.h index 7c22b53..105af4d 100644 --- a/chrome/browser/extensions/user_script_listener.h +++ b/chrome/browser/extensions/user_script_listener.h @@ -26,7 +26,7 @@ class UserScriptListener : public base::RefCountedThreadSafe<UserScriptListener>, public NotificationObserver { public: - UserScriptListener(ResourceDispatcherHost* rdh); + explicit UserScriptListener(ResourceDispatcherHost* rdh); void OnResourceDispatcherHostGone() { resource_dispatcher_host_ = NULL; } diff --git a/chrome/browser/extensions/user_script_master.h b/chrome/browser/extensions/user_script_master.h index a8c3fa6..ff1e589 100644 --- a/chrome/browser/extensions/user_script_master.h +++ b/chrome/browser/extensions/user_script_master.h @@ -28,7 +28,7 @@ class UserScriptMaster : public base::RefCountedThreadSafe<UserScriptMaster>, public: // For testability, the constructor takes the path the scripts live in. // This is normally a directory inside the profile. - UserScriptMaster(const FilePath& script_dir); + explicit UserScriptMaster(const FilePath& script_dir); // Add a watched directory. All scripts will be reloaded when any file in // this directory changes. |