diff options
| author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-16 00:05:52 +0000 |
|---|---|---|
| committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-16 00:05:52 +0000 |
| commit | 17bc2fda0ad39f2d3599de486ee065986a33c00c (patch) | |
| tree | 99349656ead85591e448b7be62c932fb4682c53a /chrome/browser/extensions | |
| parent | 66f4409a9cd01bf8f622e62fd4403bd9c541967f (diff) | |
| download | chromium_src-17bc2fda0ad39f2d3599de486ee065986a33c00c.zip chromium_src-17bc2fda0ad39f2d3599de486ee065986a33c00c.tar.gz chromium_src-17bc2fda0ad39f2d3599de486ee065986a33c00c.tar.bz2 | |
Miscellaneous API sprucing.
- Camel-case event names.
- Rename chromium.self in content scripts to chromium.extension.
- Move onConnect in extension process to chromium.self.onConnect.
- Move definition of chromium.self to extension_process_bindings.js, so that it is near all the other extension process API.
- Make toolstrips not wrap by default
- Make toolstrips 21px high instead of 19, which was required to avoid an ugly white horizontal bar on my machine. This may be font dependent :(, which is another reason I need to finish making us paint the toolstrips background instead of using this CSS hack.
Review URL: http://codereview.chromium.org/67162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13816 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
| -rw-r--r-- | chrome/browser/extensions/extension_messages_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/extensions/extension_messages_unittest.cc b/chrome/browser/extensions/extension_messages_unittest.cc index 565f664..009d574 100644 --- a/chrome/browser/extensions/extension_messages_unittest.cc +++ b/chrome/browser/extensions/extension_messages_unittest.cc @@ -15,7 +15,7 @@ TEST_F(RenderViewTest, ExtensionMessagesOpenChannel) { ExecuteJavaScript( "var e = new chromium.Extension('foobar');" "var port = e.connect();" - "port.onmessage.addListener(doOnMessage);" + "port.onMessage.addListener(doOnMessage);" "port.postMessage({message: 'content ready'});" "function doOnMessage(msg, port) {" " alert('content got: ' + msg.val);" @@ -56,8 +56,8 @@ TEST_F(RenderViewTest, ExtensionMessagesOpenChannel) { TEST_F(RenderViewTest, ExtensionMessagesOnConnect) { LoadHTML("<body></body>"); ExecuteJavaScript( - "chromium.onconnect.addListener(function (port) {" - " port.onmessage.addListener(doOnMessage);" + "chromium.self.onConnect.addListener(function (port) {" + " port.onMessage.addListener(doOnMessage);" " port.postMessage({message: 'onconnect'});" "});" "function doOnMessage(msg, port) {" |