summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
diff options
context:
space:
mode:
authortfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-02 19:20:13 +0000
committertfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-02 19:20:13 +0000
commit1db06851c0de18c6049a88379750f5651cc92a75 (patch)
treeb73c3fc45a07f77ab55fc3de83c4e035b5ba2387 /chrome/browser/extensions
parent7fef9717afc4570883a9207fb8ea70f295685488 (diff)
downloadchromium_src-1db06851c0de18c6049a88379750f5651cc92a75.zip
chromium_src-1db06851c0de18c6049a88379750f5651cc92a75.tar.gz
chromium_src-1db06851c0de18c6049a88379750f5651cc92a75.tar.bz2
Add a Delegate to JavaScriptAppModalDialog.
Done a couples of things here: - Renamed JavaScriptMessageBoxClient to JavaScriptMessageBoxDelegate (since this is a common pattern in chrome and helps the reader to find out where the message box goes). - Moved that class into js_modal_dialog.h file. - Deleted jsmessage_box_client.h It is a following to http://codereview.chromium.org/3384036. BUG=54988 TEST=trybots Review URL: http://codereview.chromium.org/3576003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61309 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
-rw-r--r--chrome/browser/extensions/extension_host.h8
1 files changed, 4 insertions, 4 deletions
diff --git a/chrome/browser/extensions/extension_host.h b/chrome/browser/extensions/extension_host.h
index fda120a..fe208c8 100644
--- a/chrome/browser/extensions/extension_host.h
+++ b/chrome/browser/extensions/extension_host.h
@@ -12,7 +12,7 @@
#include "base/perftimer.h"
#include "base/scoped_ptr.h"
#include "chrome/browser/extensions/extension_function_dispatcher.h"
-#include "chrome/browser/jsmessage_box_client.h"
+#include "chrome/browser/js_modal_dialog.h"
#include "chrome/browser/renderer_host/render_view_host_delegate.h"
#include "chrome/browser/tab_contents/render_view_host_delegate_helper.h"
#if defined(TOOLKIT_VIEWS)
@@ -40,7 +40,7 @@ class ExtensionHost : public RenderViewHostDelegate,
public RenderViewHostDelegate::View,
public ExtensionFunctionDispatcher::Delegate,
public NotificationObserver,
- public JavaScriptMessageBoxClient {
+ public JavaScriptAppModalDialogDelegate {
public:
class ProcessCreationQueue;
@@ -180,12 +180,12 @@ class ExtensionHost : public RenderViewHostDelegate,
const NotificationSource& source,
const NotificationDetails& details);
- // JavaScriptMessageBoxClient
- virtual gfx::NativeWindow GetMessageBoxRootWindow();
+ // Overridden from JavaScriptAppModalDialogDelegate:
virtual void OnMessageBoxClosed(IPC::Message* reply_msg,
bool success,
const std::wstring& prompt);
virtual void SetSuppressMessageBoxes(bool suppress_message_boxes) {}
+ virtual gfx::NativeWindow GetMessageBoxRootWindow();
virtual TabContents* AsTabContents() { return NULL; }
virtual ExtensionHost* AsExtensionHost() { return this; }