diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-05 23:46:02 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-05 23:46:02 +0000 |
commit | 2858bbf9099f835325422009c5945e9b26a97d42 (patch) | |
tree | 4751ec07dc414566f15d9995386b73805facfca0 /chrome/browser/extensions | |
parent | e22ddddb19c659dce909396cb2320979cbedc5d2 (diff) | |
download | chromium_src-2858bbf9099f835325422009c5945e9b26a97d42.zip chromium_src-2858bbf9099f835325422009c5945e9b26a97d42.tar.gz chromium_src-2858bbf9099f835325422009c5945e9b26a97d42.tar.bz2 |
FBTF: Continue fixing nits found by my automated source scanner.
(~1.3 megs off Debug linux .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3556013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
6 files changed, 15 insertions, 4 deletions
diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc index 88546bd..9c7a1cf 100644 --- a/chrome/browser/extensions/extension_prefs.cc +++ b/chrome/browser/extensions/extension_prefs.cc @@ -122,6 +122,8 @@ ExtensionPrefs::ExtensionPrefs(PrefService* prefs, const FilePath& root_dir) MakePathsRelative(); } +ExtensionPrefs::~ExtensionPrefs() {} + // static const char ExtensionPrefs::kExtensionsPref[] = "extensions.settings"; diff --git a/chrome/browser/extensions/extension_prefs.h b/chrome/browser/extensions/extension_prefs.h index 01226cd..98db9dc 100644 --- a/chrome/browser/extensions/extension_prefs.h +++ b/chrome/browser/extensions/extension_prefs.h @@ -37,6 +37,7 @@ class ExtensionPrefs { }; explicit ExtensionPrefs(PrefService* prefs, const FilePath& root_dir_); + ~ExtensionPrefs(); // Returns a copy of the Extensions prefs. // TODO(erikkay) Remove this so that external consumers don't need to be diff --git a/chrome/browser/extensions/extensions_quota_service.cc b/chrome/browser/extensions/extensions_quota_service.cc index de5b926..7a404642 100644 --- a/chrome/browser/extensions/extensions_quota_service.cc +++ b/chrome/browser/extensions/extensions_quota_service.cc @@ -83,6 +83,13 @@ void QuotaLimitHeuristic::Bucket::Reset(const Config& config, expiration_ = start + config.refill_interval; } +QuotaLimitHeuristic::QuotaLimitHeuristic(const Config& config, + BucketMapper* map) + : config_(config), bucket_mapper_(map) { +} + +QuotaLimitHeuristic::~QuotaLimitHeuristic() {} + bool QuotaLimitHeuristic::ApplyToArgs(const ListValue* args, const base::TimeTicks& event_time) { BucketList buckets; diff --git a/chrome/browser/extensions/extensions_quota_service.h b/chrome/browser/extensions/extensions_quota_service.h index c60a5d3..b9880d0 100644 --- a/chrome/browser/extensions/extensions_quota_service.h +++ b/chrome/browser/extensions/extensions_quota_service.h @@ -142,9 +142,8 @@ class QuotaLimitHeuristic { }; // Ownership of |mapper| is given to the new QuotaLimitHeuristic. - explicit QuotaLimitHeuristic(const Config& config, BucketMapper* map) - : config_(config), bucket_mapper_(map) {} - virtual ~QuotaLimitHeuristic() {} + explicit QuotaLimitHeuristic(const Config& config, BucketMapper* map); + virtual ~QuotaLimitHeuristic(); // Determines if sufficient quota exists (according to the Apply // implementation of a derived class) to perform an operation with |args|, diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker.cc b/chrome/browser/extensions/sandboxed_extension_unpacker.cc index 1c5e319..022351b 100644 --- a/chrome/browser/extensions/sandboxed_extension_unpacker.cc +++ b/chrome/browser/extensions/sandboxed_extension_unpacker.cc @@ -116,6 +116,8 @@ void SandboxedExtensionUnpacker::Start() { } } +SandboxedExtensionUnpacker::~SandboxedExtensionUnpacker() {} + void SandboxedExtensionUnpacker::StartProcessOnIOThread( const FilePath& temp_crx_path) { UtilityProcessHost* host = new UtilityProcessHost( diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker.h b/chrome/browser/extensions/sandboxed_extension_unpacker.h index 00ee232..c9de32d 100644 --- a/chrome/browser/extensions/sandboxed_extension_unpacker.h +++ b/chrome/browser/extensions/sandboxed_extension_unpacker.h @@ -105,7 +105,7 @@ class SandboxedExtensionUnpacker : public UtilityProcessHost::Client { friend class ProcessHostClient; friend class SandboxedExtensionUnpackerTest; - ~SandboxedExtensionUnpacker() {} + virtual ~SandboxedExtensionUnpacker(); // Validates the signature of the extension and extract the key to // |public_key_|. Returns true if the signature validates, false otherwise. |