diff options
author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-10 03:20:28 +0000 |
---|---|---|
committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-10 03:20:28 +0000 |
commit | 29679dea4bde2ef6f085f54975d483a90c8d10ac (patch) | |
tree | e91f2d28f2d469b54045cd9468be9a34cbbe87a0 /chrome/browser/extensions | |
parent | f51f873ba01bfcc8b54342934ebd64731c51990c (diff) | |
download | chromium_src-29679dea4bde2ef6f085f54975d483a90c8d10ac.zip chromium_src-29679dea4bde2ef6f085f54975d483a90c8d10ac.tar.gz chromium_src-29679dea4bde2ef6f085f54975d483a90c8d10ac.tar.bz2 |
[Coverity] Changed pass-by-value to pass-by-ref
CID=102148
TBR=jstritar@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9669020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125992 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
-rw-r--r-- | chrome/browser/extensions/webstore_installer.cc | 8 | ||||
-rw-r--r-- | chrome/browser/extensions/webstore_installer.h | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc index 91aa03d..6eb61da 100644 --- a/chrome/browser/extensions/webstore_installer.cc +++ b/chrome/browser/extensions/webstore_installer.cc @@ -75,9 +75,9 @@ GURL GetWebstoreInstallURL( } // Must be executed on the FILE thread. -void GetDownloadFilePath(const FilePath& download_directory, - const std::string& id, - const base::Callback<void(FilePath)>& callback) { +void GetDownloadFilePath( + const FilePath& download_directory, const std::string& id, + const base::Callback<void(const FilePath&)>& callback) { const FilePath& directory(g_download_directory_for_tests ? *g_download_directory_for_tests : download_directory); @@ -188,7 +188,7 @@ void WebstoreInstaller::SetDownloadDirectoryForTests(FilePath* directory) { g_download_directory_for_tests = directory; } -void WebstoreInstaller::StartDownload(FilePath file) { +void WebstoreInstaller::StartDownload(const FilePath& file) { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); if (file.empty()) { diff --git a/chrome/browser/extensions/webstore_installer.h b/chrome/browser/extensions/webstore_installer.h index 91656fe..33dadf0 100644 --- a/chrome/browser/extensions/webstore_installer.h +++ b/chrome/browser/extensions/webstore_installer.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -69,7 +69,7 @@ class WebstoreInstaller : public content::NotificationObserver, private: // Starts downloading the extension to |file_path|. - void StartDownload(FilePath file_path); + void StartDownload(const FilePath& file_path); // Reports an install |error| to the delegate for the given extension if this // managed its installation. This also removes the associated PendingInstall. |