diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-18 00:42:57 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-18 00:42:57 +0000 |
| commit | 830656f089f62fd3b19d4a080644357e36630b3a (patch) | |
| tree | 543c07998c011ad3f3ba878de40c65c63a7315d7 /chrome/browser/extensions | |
| parent | 0956603c9d6117296cdba3162015af5ae0463b8e (diff) | |
| download | chromium_src-830656f089f62fd3b19d4a080644357e36630b3a.zip chromium_src-830656f089f62fd3b19d4a080644357e36630b3a.tar.gz chromium_src-830656f089f62fd3b19d4a080644357e36630b3a.tar.bz2 | |
While fixing bug 22070 (Toolstrip theme background not updated when resizing Chrome window) I added code to trigger repainting the background on resize. This flushed out a problem (Skia exceptions) that was causing the extension tests to become flaky on the bots (bug 22135). I've changed the code to do a deep copy on the subset bitmap we get before passing it down to the renderer, which causes Skia to not go haywire when drawing the background.
That makes it possible to fix bug 22070, which now causes the background to be updated on resize. There is also now no need to set the background_needs_repaint_ flag to true before calling Layout. We also don't need to keep track of whether we are detached or not, we just need to monitor the background_needs_repaint_ flag.
BUG=22070, 22135
TEST=Monitor the bots and see if the tests become flaky again.
Review URL: http://codereview.chromium.org/215017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26526 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
| -rw-r--r-- | chrome/browser/extensions/extension_browsertests_misc.cc | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/chrome/browser/extensions/extension_browsertests_misc.cc b/chrome/browser/extensions/extension_browsertests_misc.cc index 9432e66..490ef9c 100644 --- a/chrome/browser/extensions/extension_browsertests_misc.cc +++ b/chrome/browser/extensions/extension_browsertests_misc.cc @@ -50,8 +50,7 @@ static ExtensionHost* FindHostWithPath(ExtensionProcessManager* manager, } // Tests that toolstrips initializes properly and can run basic extension js. -// Disabled, see bug 22135 -IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_Toolstrip) { +IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, Toolstrip) { FilePath extension_test_data_dir = test_data_dir_.AppendASCII("good"). AppendASCII("Extensions").AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj"). AppendASCII("1.0.0.0"); @@ -88,8 +87,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_Toolstrip) { } #if defined(OS_WIN) // TODO(port) -- enable -// Disabled, see bug 22135 -IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DIABLED_ExtensionViews) { +IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, ExtensionViews) { FilePath extension_test_data_dir = test_data_dir_.AppendASCII("good"). AppendASCII("Extensions").AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj"). AppendASCII("1.0.0.0"); |