diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-04 00:46:20 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-04 00:46:20 +0000 |
commit | cdcb1dee07b6c8e7fe968b2a5f4199c9c8fb2323 (patch) | |
tree | 4a9218cc8e53e78e565140e5e88d85c29280117e /chrome/browser/extensions | |
parent | 46a7e02c5bba1b9c68f86befaf586d0b17eb0b04 (diff) | |
download | chromium_src-cdcb1dee07b6c8e7fe968b2a5f4199c9c8fb2323.zip chromium_src-cdcb1dee07b6c8e7fe968b2a5f4199c9c8fb2323.tar.gz chromium_src-cdcb1dee07b6c8e7fe968b2a5f4199c9c8fb2323.tar.bz2 |
Convert WebContents to return a content::NavigationController instead of the implementation. Update all the headers in chrome to use the interface only. In a subsequent cl, I'll rename the implementation to NavigationControllerImpl and also get rid of content::NavigationController everywhere.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8983010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116244 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
8 files changed, 17 insertions, 13 deletions
diff --git a/chrome/browser/extensions/extension_browser_event_router.cc b/chrome/browser/extensions/extension_browser_event_router.cc index 62d320c..dc3777e 100644 --- a/chrome/browser/extensions/extension_browser_event_router.cc +++ b/chrome/browser/extensions/extension_browser_event_router.cc @@ -18,7 +18,7 @@ #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_constants.h" -#include "content/browser/tab_contents/navigation_controller.h" +#include "content/public/browser/navigation_controller.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/web_contents.h" diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc index 320525e..a63ea8d 100644 --- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc +++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc @@ -18,7 +18,7 @@ #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" #include "chrome/test/base/ui_test_utils.h" #include "content/browser/renderer_host/render_view_host.h" -#include "content/browser/tab_contents/navigation_controller.h" +#include "content/public/browser/navigation_controller.h" #include "content/public/browser/render_process_host.h" #include "content/public/browser/web_contents.h" #include "content/public/common/result_codes.h" diff --git a/chrome/browser/extensions/extension_navigation_observer.cc b/chrome/browser/extensions/extension_navigation_observer.cc index 18a4edf..4af29cc 100644 --- a/chrome/browser/extensions/extension_navigation_observer.cc +++ b/chrome/browser/extensions/extension_navigation_observer.cc @@ -6,7 +6,7 @@ #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/profiles/profile.h" -#include "content/browser/tab_contents/navigation_controller.h" +#include "content/public/browser/navigation_controller.h" #include "content/public/browser/navigation_entry.h" #include "content/public/browser/notification_service.h" diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc index 10de472..4848529 100644 --- a/chrome/browser/extensions/extension_tabs_module.cc +++ b/chrome/browser/extensions/extension_tabs_module.cc @@ -46,8 +46,8 @@ #include "content/browser/renderer_host/backing_store.h" #include "content/browser/renderer_host/render_view_host.h" #include "content/browser/renderer_host/render_view_host_delegate.h" -#include "content/browser/tab_contents/navigation_controller.h" #include "content/browser/tab_contents/tab_contents_view.h" +#include "content/public/browser/navigation_controller.h" #include "content/public/browser/navigation_entry.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_source.h" @@ -1072,7 +1072,8 @@ bool UpdateTabFunction::RunImpl() { NULL, &tab_strip, &contents, &tab_index, &error_)) { return false; } - NavigationController& controller = contents->web_contents()->GetController(); + content::NavigationController& controller = + contents->web_contents()->GetController(); // TODO(rafaelw): handle setting remaining tab properties: // -title diff --git a/chrome/browser/extensions/extension_url_rewrite_browsertest.cc b/chrome/browser/extensions/extension_url_rewrite_browsertest.cc index 333fa3a..fa7e5df 100644 --- a/chrome/browser/extensions/extension_url_rewrite_browsertest.cc +++ b/chrome/browser/extensions/extension_url_rewrite_browsertest.cc @@ -14,7 +14,7 @@ #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/ui_test_utils.h" -#include "content/browser/tab_contents/navigation_controller.h" +#include "content/public/browser/navigation_controller.h" #include "content/public/browser/navigation_entry.h" #include "content/public/browser/web_contents.h" #include "googleurl/src/gurl.h" @@ -32,7 +32,7 @@ class ExtensionURLRewriteBrowserTest : public ExtensionBrowserTest { return GURL(GetLocationBarText()); } - NavigationController* GetNavigationController() const { + content::NavigationController* GetNavigationController() const { return &browser()->GetSelectedWebContents()->GetController(); } diff --git a/chrome/browser/extensions/extension_web_ui.cc b/chrome/browser/extensions/extension_web_ui.cc index 60790e75..f471122 100644 --- a/chrome/browser/extensions/extension_web_ui.cc +++ b/chrome/browser/extensions/extension_web_ui.cc @@ -24,7 +24,7 @@ #include "chrome/common/extensions/extension_icon_set.h" #include "chrome/common/extensions/extension_resource.h" #include "chrome/common/url_constants.h" -#include "content/browser/tab_contents/navigation_controller.h" +#include "content/public/browser/navigation_controller.h" #include "content/public/browser/web_contents.h" #include "content/public/common/page_transition_types.h" #include "content/public/common/bindings_policy.h" diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc index ecd0223..c475c73 100644 --- a/chrome/browser/extensions/webstore_installer.cc +++ b/chrome/browser/extensions/webstore_installer.cc @@ -22,10 +22,10 @@ #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_constants.h" #include "content/browser/download/download_types.h" -#include "content/browser/tab_contents/navigation_controller.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/download_file.h" #include "content/public/browser/download_manager.h" +#include "content/public/browser/navigation_controller.h" #include "content/public/browser/navigation_entry.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_source.h" @@ -104,7 +104,7 @@ void GetDownloadFilePath(const std::string& id, WebstoreInstaller::WebstoreInstaller(Profile* profile, Delegate* delegate, - NavigationController* controller, + content::NavigationController* controller, const std::string& id, int flags) : profile_(profile), diff --git a/chrome/browser/extensions/webstore_installer.h b/chrome/browser/extensions/webstore_installer.h index 345df9f..91656fe 100644 --- a/chrome/browser/extensions/webstore_installer.h +++ b/chrome/browser/extensions/webstore_installer.h @@ -16,9 +16,12 @@ #include "googleurl/src/gurl.h" class FilePath; -class NavigationController; class Profile; +namespace content { +class NavigationController; +} + // Downloads and installs extensions from the web store. class WebstoreInstaller : public content::NotificationObserver, public base::RefCounted<WebstoreInstaller> { @@ -47,7 +50,7 @@ class WebstoreInstaller : public content::NotificationObserver, // Note: the delegate should stay alive until being called back. WebstoreInstaller(Profile* profile, Delegate* delegate, - NavigationController* controller, + content::NavigationController* controller, const std::string& id, int flags); virtual ~WebstoreInstaller(); @@ -80,7 +83,7 @@ class WebstoreInstaller : public content::NotificationObserver, content::NotificationRegistrar registrar_; Profile* profile_; Delegate* delegate_; - NavigationController* controller_; + content::NavigationController* controller_; std::string id_; int flags_; GURL download_url_; |