diff options
| author | joth@chromium.org <joth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-21 09:37:13 +0000 |
|---|---|---|
| committer | joth@chromium.org <joth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-21 09:37:13 +0000 |
| commit | 2b1d9f1e40a879897f13c0189757ebd135ade38b (patch) | |
| tree | 4ebad79e51561460834cd65181c3940f3cc0d66d /chrome/browser/favicon | |
| parent | bd183ec2e20df5d2c18ace26cbb0c1c0ede1d70a (diff) | |
| download | chromium_src-2b1d9f1e40a879897f13c0189757ebd135ade38b.zip chromium_src-2b1d9f1e40a879897f13c0189757ebd135ade38b.tar.gz chromium_src-2b1d9f1e40a879897f13c0189757ebd135ade38b.tar.bz2 | |
Added RefCountedString, as this is what many RefCountedMemory users seem to want
Made data member of RefCountedBytes private, as per style guide
Changed base64 APIs to accept StringPiece, as it's sometimes better and never worse than string.
BUG=None
TEST=All existing tests pass. Extended ref_counted_memory_unittests
Review URL: http://codereview.chromium.org/7397021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93365 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/favicon')
| -rw-r--r-- | chrome/browser/favicon/favicon_handler_unittest.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/favicon/favicon_handler_unittest.cc b/chrome/browser/favicon/favicon_handler_unittest.cc index c2cc69a..a76192d 100644 --- a/chrome/browser/favicon/favicon_handler_unittest.cc +++ b/chrome/browser/favicon/favicon_handler_unittest.cc @@ -329,7 +329,7 @@ TEST_F(FaviconHandlerTest, GetFaviconFromHistory) { history_handler->favicon_data_.expired = false; history_handler->favicon_data_.icon_url = icon_url; scoped_refptr<RefCountedBytes> data = new RefCountedBytes(); - FillBitmap(kFaviconSize, kFaviconSize, &data->data); + FillBitmap(kFaviconSize, kFaviconSize, &data->data()); history_handler->favicon_data_.image_data = data; // Send history response. @@ -442,7 +442,7 @@ TEST_F(FaviconHandlerTest, UpdateAndDownloadFavicon) { history_handler->favicon_data_.expired = false; history_handler->favicon_data_.icon_url = icon_url; scoped_refptr<RefCountedBytes> data = new RefCountedBytes(); - FillBitmap(kFaviconSize, kFaviconSize, &data->data); + FillBitmap(kFaviconSize, kFaviconSize, &data->data()); history_handler->favicon_data_.image_data = data; // Send history response. @@ -529,7 +529,7 @@ TEST_F(FaviconHandlerTest, UpdateFavicon) { history_handler->favicon_data_.expired = false; history_handler->favicon_data_.icon_url = icon_url; scoped_refptr<RefCountedBytes> data = new RefCountedBytes(); - FillBitmap(kFaviconSize, kFaviconSize, &data->data); + FillBitmap(kFaviconSize, kFaviconSize, &data->data()); history_handler->favicon_data_.image_data = data; // Send history response. @@ -671,7 +671,7 @@ TEST_F(FaviconHandlerTest, Download2ndFaviconURLCandidate) { history_handler->favicon_data_.expired = true; history_handler->favicon_data_.icon_url = new_icon_url; scoped_refptr<RefCountedBytes> data = new RefCountedBytes(); - FillBitmap(kFaviconSize, kFaviconSize, &data->data); + FillBitmap(kFaviconSize, kFaviconSize, &data->data()); history_handler->favicon_data_.image_data = data; history_handler->InvokeCallback(); @@ -800,7 +800,7 @@ TEST_F(FaviconHandlerTest, UpdateDuringDownloading) { handler->favicon_data_.icon_type = history::TOUCH_ICON; handler->favicon_data_.icon_url = latest_icon_url; scoped_refptr<RefCountedBytes> data = new RefCountedBytes(); - FillBitmap(kFaviconSize, kFaviconSize, &data->data); + FillBitmap(kFaviconSize, kFaviconSize, &data->data()); handler->favicon_data_.image_data = data; handler->InvokeCallback(); |