summaryrefslogtreecommitdiffstats
path: root/chrome/browser/geolocation
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-01 20:25:23 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-01 20:25:23 +0000
commitcb2edf23d2553c6e13d070a33f9f2b9613d21ab1 (patch)
tree51c0b1125dba09b873d5f4bb6b63ae8c6ad35b17 /chrome/browser/geolocation
parent6ba8fcd3ec74b24afb75821236de78677081ad29 (diff)
downloadchromium_src-cb2edf23d2553c6e13d070a33f9f2b9613d21ab1.zip
chromium_src-cb2edf23d2553c6e13d070a33f9f2b9613d21ab1.tar.gz
chromium_src-cb2edf23d2553c6e13d070a33f9f2b9613d21ab1.tar.bz2
Move the ViewType enum to extensions\common.
BUG=162530 Review URL: https://codereview.chromium.org/13375017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191650 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/geolocation')
-rw-r--r--chrome/browser/geolocation/chrome_geolocation_permission_context.cc5
-rw-r--r--chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc6
2 files changed, 6 insertions, 5 deletions
diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context.cc
index 450adc8..4bdb839 100644
--- a/chrome/browser/geolocation/chrome_geolocation_permission_context.cc
+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context.cc
@@ -19,11 +19,11 @@
#include "chrome/browser/geolocation/geolocation_permission_request_id.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/tab_contents/tab_util.h"
-#include "chrome/browser/view_type_utils.h"
#include "chrome/common/extensions/extension.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
+#include "extensions/browser/view_type_utils.h"
#include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebSecurityOrigin.h"
@@ -86,7 +86,8 @@ void ChromeGeolocationPermissionContext::RequestGeolocationPermission(
}
}
- if (chrome::GetViewType(web_contents) != chrome::VIEW_TYPE_TAB_CONTENTS) {
+ if (extensions::GetViewType(web_contents) !=
+ extensions::VIEW_TYPE_TAB_CONTENTS) {
// The tab may have gone away, or the request may not be from a tab at all.
// TODO(mpcomplete): the request could be from a background page or
// extension popup (web_contents will have a different ViewType). But why do
diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
index 1baef2b..400269c 100644
--- a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
@@ -18,7 +18,6 @@
#include "chrome/browser/infobars/confirm_infobar_delegate.h"
#include "chrome/browser/infobars/infobar.h"
#include "chrome/browser/infobars/infobar_service.h"
-#include "chrome/browser/view_type_utils.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "chrome/test/base/testing_profile.h"
@@ -30,6 +29,7 @@
#include "content/public/test/test_browser_thread.h"
#include "content/public/test/test_renderer_host.h"
#include "content/public/test/web_contents_tester.h"
+#include "extensions/browser/view_type_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
#if defined(OS_ANDROID)
@@ -230,7 +230,7 @@ void GeolocationPermissionContextTests::AddNewTab(const GURL& url) {
SendNavigate(extra_tabs_.size() + 1, url);
// Set up required helpers, and make this be as "tabby" as the code requires.
- chrome::SetViewType(new_tab, chrome::VIEW_TYPE_TAB_CONTENTS);
+ extensions::SetViewType(new_tab, extensions::VIEW_TYPE_TAB_CONTENTS);
InfoBarService::CreateForWebContents(new_tab);
extra_tabs_.push_back(new_tab);
@@ -257,7 +257,7 @@ void GeolocationPermissionContextTests::SetUp() {
ChromeRenderViewHostTestHarness::SetUp();
// Set up required helpers, and make this be as "tabby" as the code requires.
- chrome::SetViewType(web_contents(), chrome::VIEW_TYPE_TAB_CONTENTS);
+ extensions::SetViewType(web_contents(), extensions::VIEW_TYPE_TAB_CONTENTS);
InfoBarService::CreateForWebContents(web_contents());
TabSpecificContentSettings::CreateForWebContents(web_contents());
#if defined(OS_ANDROID)