diff options
| author | fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-03 06:03:58 +0000 |
|---|---|---|
| committer | fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-03 06:03:58 +0000 |
| commit | b6bcd8c0995b6c60a515db642a92fea7808542e9 (patch) | |
| tree | 7b050178a24b6aba87b3c1e6bde86fd839e27cfc /chrome/browser/global_keyboard_shortcuts_mac.h | |
| parent | d4b437ef5bb409763c7985e7a2348f80f6852d52 (diff) | |
| download | chromium_src-b6bcd8c0995b6c60a515db642a92fea7808542e9.zip chromium_src-b6bcd8c0995b6c60a515db642a92fea7808542e9.tar.gz chromium_src-b6bcd8c0995b6c60a515db642a92fea7808542e9.tar.bz2 | |
Browser Plugin: Fixed browser process crash on embedder reload.
The browser process crashed because a CHECK that verifies that an existing browser_plugin_embedder_ does not yet exist fails.
This happens because CreateGuest should only be handled in WebContentsImpl on the first call to CreateGuest. On all subsequent calls, CreateGuest should be handled in BrowserPluginEmbedderHelper.
This patch makes this change.
I've also cleaned up some dead code.
I've also written a test that verifies that reloading the embedder
doesn't cause the browser plugin to misbehave.
BUG=153561
Test=BrowserPluginHostTest.ReloadEmbedder
Review URL: https://chromiumcodereview.appspot.com/11046002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159854 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/global_keyboard_shortcuts_mac.h')
0 files changed, 0 insertions, 0 deletions