diff options
author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-06 05:52:42 +0000 |
---|---|---|
committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-06 05:52:42 +0000 |
commit | ae8be5cadd06887ae263a9e906afe297e8cffb8b (patch) | |
tree | 7aea263fbe566a3d1d00943693ceaa64fc63cd2e /chrome/browser/google_apis/gdata_wapi_parser.h | |
parent | 016bb66b4dc5d384b379ea5e7ff9f099e4e85221 (diff) | |
download | chromium_src-ae8be5cadd06887ae263a9e906afe297e8cffb8b.zip chromium_src-ae8be5cadd06887ae263a9e906afe297e8cffb8b.tar.gz chromium_src-ae8be5cadd06887ae263a9e906afe297e8cffb8b.tar.bz2 |
drive: Return scoped_ptr<> instead of a raw pointer from DocumentEntry
To make the ownershp of the return object clear.
BUG=148705
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11369045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166153 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/google_apis/gdata_wapi_parser.h')
-rw-r--r-- | chrome/browser/google_apis/gdata_wapi_parser.h | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/chrome/browser/google_apis/gdata_wapi_parser.h b/chrome/browser/google_apis/gdata_wapi_parser.h index 0a716b4c..dc7edcf 100644 --- a/chrome/browser/google_apis/gdata_wapi_parser.h +++ b/chrome/browser/google_apis/gdata_wapi_parser.h @@ -353,24 +353,26 @@ class DocumentEntry : public FeedEntry { // } // // The caller should delete the returned object. - static DocumentEntry* ExtractAndParse(const base::Value& value); + static scoped_ptr<DocumentEntry> ExtractAndParse(const base::Value& value); // Creates document entry from parsed JSON Value. You should call // this instead of instantiating JSONValueConverter by yourself // because this method does some post-process for some fields. See // FillRemainingFields comment and implementation for the details. - static DocumentEntry* CreateFrom(const base::Value& value); + static scoped_ptr<DocumentEntry> CreateFrom(const base::Value& value); // Creates document entry from parsed XML. - static DocumentEntry* CreateFromXml(XmlReader* xml_reader); + static scoped_ptr<DocumentEntry> CreateFromXml(XmlReader* xml_reader); // Creates document entry from FileResource. // TODO(kochi): This should go away soon. http://crbug.com/142293 - static DocumentEntry* CreateFromFileResource(const FileResource& file); + static scoped_ptr<DocumentEntry> CreateFromFileResource( + const FileResource& file); // Creates document entry from ChangeResource. // Todo(Kochi): This should go away soon. http://crbug.com/142293 - static DocumentEntry* CreateFromChangeResource(const ChangeResource& change); + static scoped_ptr<DocumentEntry> CreateFromChangeResource( + const ChangeResource& change); // Returns name of entry node. static std::string GetEntryNodeName(); |