diff options
author | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-31 20:39:02 +0000 |
---|---|---|
committer | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-31 20:39:02 +0000 |
commit | fd85ad650d68309b965dbc9f3d6823cf2754349c (patch) | |
tree | 28b98629e02b2e05ec74272146f249ca62a164da /chrome/browser/importer | |
parent | ce072a7181ea5d58133e33654133236f5d9f5551 (diff) | |
download | chromium_src-fd85ad650d68309b965dbc9f3d6823cf2754349c.zip chromium_src-fd85ad650d68309b965dbc9f3d6823cf2754349c.tar.gz chromium_src-fd85ad650d68309b965dbc9f3d6823cf2754349c.tar.bz2 |
Move app/win_util to app/win and fix the namespace usage.
Split out the two classes: ScopedComInitializer and ScopedCOMem (which I renamed) to separate files.
I removed the win_util_path file which had one function in it and moved the function to win_util.
Somehow, this was getting picked up by the nacl64 build and the call in sandbox_policy was then not being
defined. I just implemented the function in-plcae since it's just a simple wrapper around a Windows API call.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6013009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70343 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/importer')
-rw-r--r-- | chrome/browser/importer/ie_importer.cc | 7 | ||||
-rw-r--r-- | chrome/browser/importer/importer.cc | 4 | ||||
-rw-r--r-- | chrome/browser/importer/importer_unittest.cc | 4 |
3 files changed, 8 insertions, 7 deletions
diff --git a/chrome/browser/importer/ie_importer.cc b/chrome/browser/importer/ie_importer.cc index efa2a0a..34b8cdb 100644 --- a/chrome/browser/importer/ie_importer.cc +++ b/chrome/browser/importer/ie_importer.cc @@ -16,7 +16,8 @@ #include <vector> #include "app/l10n_util.h" -#include "app/win_util.h" +#include "app/win/scoped_co_mem.h" +#include "app/win/scoped_com_initializer.h" #include "base/file_path.h" #include "base/file_util.h" #include "base/scoped_comptr_win.h" @@ -78,7 +79,7 @@ void IEImporter::StartImport(const ProfileInfo& profile_info, bridge_->NotifyStarted(); // Some IE settings (such as Protected Storage) are obtained via COM APIs. - win_util::ScopedCOMInitializer com_initializer; + app::win::ScopedCOMInitializer com_initializer; if ((items & importer::HOME_PAGE) && !cancelled()) ImportHomepage(); // Doesn't have a UI item. @@ -552,7 +553,7 @@ void IEImporter::ParseFavoritesFolder(const FavoritesInfo& info, } std::wstring IEImporter::ResolveInternetShortcut(const std::wstring& file) { - win_util::CoMemReleaser<wchar_t> url; + app::win::ScopedCoMem<wchar_t> url; ScopedComPtr<IUniformResourceLocator> url_locator; HRESULT result = url_locator.CreateInstance(CLSID_InternetShortcut, NULL, CLSCTX_INPROC_SERVER); diff --git a/chrome/browser/importer/importer.cc b/chrome/browser/importer/importer.cc index 6379e7b..558eb17 100644 --- a/chrome/browser/importer/importer.cc +++ b/chrome/browser/importer/importer.cc @@ -29,7 +29,7 @@ // TODO(port): Port these files. #if defined(OS_WIN) -#include "app/win_util.h" +#include "app/win/win_util.h" #include "chrome/browser/views/importer_lock_view.h" #include "views/window/window.h" #elif defined(OS_MACOSX) @@ -211,7 +211,7 @@ void ImporterHost::StartImportSettings( // credentials. if (profile_info.browser_type == importer::GOOGLE_TOOLBAR5) { if (!toolbar_importer_utils::IsGoogleGAIACookieInstalled()) { - win_util::MessageBox( + app::win::MessageBox( NULL, l10n_util::GetString(IDS_IMPORTER_GOOGLE_LOGIN_TEXT).c_str(), L"", diff --git a/chrome/browser/importer/importer_unittest.cc b/chrome/browser/importer/importer_unittest.cc index 56ac2cc..d47e9e9 100644 --- a/chrome/browser/importer/importer_unittest.cc +++ b/chrome/browser/importer/importer_unittest.cc @@ -17,6 +17,7 @@ #include <vector> +#include "app/win/scoped_com_initializer.h" #include "base/file_util.h" #include "base/message_loop.h" #include "base/path_service.h" @@ -34,7 +35,6 @@ #include "webkit/glue/password_form.h" #if defined(OS_WIN) -#include "app/win_util.h" #include "base/scoped_comptr_win.h" #include "chrome/browser/importer/ie_importer.h" #include "chrome/browser/password_manager/ie7_password.h" @@ -357,7 +357,7 @@ void WritePStore(IPStore* pstore, const GUID* type, const GUID* subtype) { TEST_F(ImporterTest, IEImporter) { // Sets up a favorites folder. - win_util::ScopedCOMInitializer com_init; + app::win::ScopedCOMInitializer com_init; std::wstring path = test_path_.ToWStringHack(); file_util::AppendToPath(&path, L"Favorites"); CreateDirectory(path.c_str(), NULL); |