diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-30 23:21:19 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-30 23:21:19 +0000 |
| commit | caf4c05195faad46eaa650c2194b0dc4c3ba80be (patch) | |
| tree | 45f896bfc815abb705e30fa537637fd63fc371aa /chrome/browser/infobars | |
| parent | 5b2798f9a666b2fce48efc8a6bd2db4aded62556 (diff) | |
| download | chromium_src-caf4c05195faad46eaa650c2194b0dc4c3ba80be.zip chromium_src-caf4c05195faad46eaa650c2194b0dc4c3ba80be.tar.gz chromium_src-caf4c05195faad46eaa650c2194b0dc4c3ba80be.tar.bz2 | |
Avoid a possible race in sync integration tests
I haven't been able to confirm this, but I suspect there are cases where
IsSynced could be evaluated before a transaction on the syncer thread and
IsTypeEncrypted would be evaluated afterwards. If that did happen, we could
leave WaitForTypeEncryption long before we ought to, which is likely to result
in test failures.
Reordering the expressions doesn't really address the root cause of the issue.
However, we know that these conditions only change in certain ways, so the
reordering should effectively hide the bug.
BUG=98607
TEST=sync_integration
Review URL: http://codereview.chromium.org/8086010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103575 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/infobars')
0 files changed, 0 insertions, 0 deletions