diff options
author | sreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-09 20:40:08 +0000 |
---|---|---|
committer | sreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-09 20:40:08 +0000 |
commit | d6773feb98254f837edcad81ad122959322fcb1b (patch) | |
tree | 6eba6d3030be837903ad3292a9b55c39dad99f6d /chrome/browser/instant/instant_controller.cc | |
parent | 6c2999b35364b8882f8b9d10275ce46caa7d3a7c (diff) | |
download | chromium_src-d6773feb98254f837edcad81ad122959322fcb1b.zip chromium_src-d6773feb98254f837edcad81ad122959322fcb1b.tar.gz chromium_src-d6773feb98254f837edcad81ad122959322fcb1b.tar.bz2 |
Restrict Instant field trial to UMA opt-in users.
Note that if the Instant experiment has already been enabled, and *then* the
user opts out of UMA, this won't disable the experiment immediately (since the
global field trial state doesn't change). Instead, it will be disabled at
browser restart. I think this is acceptable since, if the user is fiddling with
preferences after Instant has been enabled, they can already click the Instant
checkbox to turn it off.
In addition:
+ Fix a typo in the "Omnibox.QueryTime.*" histogram.
+ Update the comment in the .h file so it flows better.
BUG=91820
TEST=Disable UMA reporting (as is default in a Chromium build), and verify that the Instant experiment doesn't get enabled.
Review URL: http://codereview.chromium.org/7583012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96057 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/instant/instant_controller.cc')
-rw-r--r-- | chrome/browser/instant/instant_controller.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/instant/instant_controller.cc b/chrome/browser/instant/instant_controller.cc index 2c5a59c..63d2ca4 100644 --- a/chrome/browser/instant/instant_controller.cc +++ b/chrome/browser/instant/instant_controller.cc @@ -76,9 +76,6 @@ void InstantController::RegisterUserPrefs(PrefService* prefs) { prefs->RegisterInt64Pref(prefs::kInstantEnabledTime, false, PrefService::UNSYNCABLE_PREF); - prefs->RegisterIntegerPref(prefs::kInstantFieldTrialRandomDraw, - base::RandInt(0, 9999), - PrefService::UNSYNCABLE_PREF); PromoCounter::RegisterUserPrefs(prefs, prefs::kInstantPromo); } |