diff options
| author | sreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-04 18:08:15 +0000 |
|---|---|---|
| committer | sreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-04 18:08:15 +0000 |
| commit | 88f15b5393368eb61397c8828ef786c1b9d02172 (patch) | |
| tree | 144c1b5cbd1850fff623d868d080fd249acb4fd8 /chrome/browser/instant/instant_controller.h | |
| parent | 737cfb2a8cc57c8fbc93c2fb5997f384e01bf0cc (diff) | |
| download | chromium_src-88f15b5393368eb61397c8828ef786c1b9d02172.zip chromium_src-88f15b5393368eb61397c8828ef786c1b9d02172.tar.gz chromium_src-88f15b5393368eb61397c8828ef786c1b9d02172.tar.bz2 | |
Don't destroy instant loaders if you don't have to.
As long as the omnibox retains focus, don't delete any instant loaders. This
includes cases where the user is not typing actively, or when the user switches
tabs (but retaining focus in the omnibox). The rationale is that the user may
type at any time, so it's useful to keep the instant loaders ready to process
the user query.
BUG=none
TEST=PreloadInstantTest.*
Review URL: http://codereview.chromium.org/8085010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103938 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/instant/instant_controller.h')
| -rw-r--r-- | chrome/browser/instant/instant_controller.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/chrome/browser/instant/instant_controller.h b/chrome/browser/instant/instant_controller.h index 36ab76f..19ebcfa 100644 --- a/chrome/browser/instant/instant_controller.h +++ b/chrome/browser/instant/instant_controller.h @@ -72,9 +72,8 @@ class InstantController : public InstantLoaderDelegate { // Returns false if there is no instant preview showing. static bool CommitIfCurrent(InstantController* controller); - // Invoked as the user types in the omnibox with the url to navigate to. If - // the url is empty and there is a preview TabContents it is destroyed. If url - // is non-empty and the preview TabContents has not been created it is + // Invoked as the user types in the omnibox with the url to navigate to. If + // the url is valid and a preview TabContents has not been created, it is // created. If |verbatim| is true search results are shown for |user_text| // rather than the best guess as to what the search thought the user meant. // |verbatim| only matters if the AutocompleteMatch is for a search engine |