diff options
| author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-21 20:14:11 +0000 |
|---|---|---|
| committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-21 20:14:11 +0000 |
| commit | 853e01bca8ffa73b4dc2ebccee8e59977f9e615e (patch) | |
| tree | 94d032772f49c28ec007b53bcf527e5a38b4e41f /chrome/browser/instant/instant_loader.cc | |
| parent | 75e313e16cd1b984f8661c657b8ae77d54201ff9 (diff) | |
| download | chromium_src-853e01bca8ffa73b4dc2ebccee8e59977f9e615e.zip chromium_src-853e01bca8ffa73b4dc2ebccee8e59977f9e615e.tar.gz chromium_src-853e01bca8ffa73b4dc2ebccee8e59977f9e615e.tar.bz2 | |
Rework arguments of HistoryService::AddPage()
In preparation for adding a timestamp to NavigationEntry, explicitly
add a time argument to all variants of HistoryService::AddPage().
Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it.
Make arguments to AddPage() match HistoryAddPageArgs constructor.
Make HistoryBackend::AddPage avoid mutating its parameter.
BUG=128449
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/10963018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/instant/instant_loader.cc')
| -rw-r--r-- | chrome/browser/instant/instant_loader.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/instant/instant_loader.cc b/chrome/browser/instant/instant_loader.cc index 5d6d9c7..4898310 100644 --- a/chrome/browser/instant/instant_loader.cc +++ b/chrome/browser/instant/instant_loader.cc @@ -172,7 +172,7 @@ bool InstantLoader::WebContentsDelegateImpl::OnGoToEntryOffset(int offset) { bool InstantLoader::WebContentsDelegateImpl::ShouldAddNavigationToHistory( const history::HistoryAddPageArgs& add_page_args, content::NavigationType navigation_type) { - loader_->last_navigation_ = add_page_args.Clone(); + loader_->last_navigation_ = add_page_args; return false; } @@ -312,7 +312,7 @@ void InstantLoader::Init() { void InstantLoader::Update(const string16& user_text, bool verbatim) { // TODO: Support real cursor position. - last_navigation_ = NULL; + last_navigation_ = history::HistoryAddPageArgs(); content::RenderViewHost* rvh = preview_contents_->web_contents()->GetRenderViewHost(); rvh->Send(new ChromeViewMsg_SearchBoxChange(rvh->GetRoutingID(), user_text, |