diff options
author | dcheng <dcheng@chromium.org> | 2014-10-22 23:36:40 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-23 06:36:57 +0000 |
commit | 4906efc327416caecff3c7c91fcaaf889c76be05 (patch) | |
tree | c4939a3235572981a15d523067da927a24d43d7d /chrome/browser/local_discovery/cloud_device_list.h | |
parent | 813cb6cd34822072dd6b0bc1744c31ff4c0bac88 (diff) | |
download | chromium_src-4906efc327416caecff3c7c91fcaaf889c76be05.zip chromium_src-4906efc327416caecff3c7c91fcaaf889c76be05.tar.gz chromium_src-4906efc327416caecff3c7c91fcaaf889c76be05.tar.bz2 |
Standardize usage of virtual/override/final in chrome/browser/local_discovery
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=gene@chromium.org
Review URL: https://codereview.chromium.org/673473002
Cr-Commit-Position: refs/heads/master@{#300848}
Diffstat (limited to 'chrome/browser/local_discovery/cloud_device_list.h')
-rw-r--r-- | chrome/browser/local_discovery/cloud_device_list.h | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/chrome/browser/local_discovery/cloud_device_list.h b/chrome/browser/local_discovery/cloud_device_list.h index baff562..1f75efd 100644 --- a/chrome/browser/local_discovery/cloud_device_list.h +++ b/chrome/browser/local_discovery/cloud_device_list.h @@ -20,14 +20,13 @@ class CloudDeviceList : public GCDApiFlowRequest { typedef DeviceList::const_iterator iterator; explicit CloudDeviceList(CloudDeviceListDelegate* delegate); - virtual ~CloudDeviceList(); + ~CloudDeviceList() override; - virtual void OnGCDAPIFlowError(GCDApiFlow::Status status) override; + void OnGCDAPIFlowError(GCDApiFlow::Status status) override; - virtual void OnGCDAPIFlowComplete( - const base::DictionaryValue& value) override; + void OnGCDAPIFlowComplete(const base::DictionaryValue& value) override; - virtual GURL GetURL() override; + GURL GetURL() override; private: bool FillDeviceDetails(const base::DictionaryValue& value, |