diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-30 23:29:18 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-30 23:29:18 +0000 |
| commit | b0349dfbcee4b07bb2d466f4c8d422a26868111d (patch) | |
| tree | afd8def3a010d119124eb58e832304067124c997 /chrome/browser/metrics/metrics_log_serializer.h | |
| parent | caf4c05195faad46eaa650c2194b0dc4c3ba80be (diff) | |
| download | chromium_src-b0349dfbcee4b07bb2d466f4c8d422a26868111d.zip chromium_src-b0349dfbcee4b07bb2d466f4c8d422a26868111d.tar.gz chromium_src-b0349dfbcee4b07bb2d466f4c8d422a26868111d.tar.bz2 | |
Fix crashes with infobar closure.
I forgot that not all InfoBarView subclasses (e.g. LinkInfoBar) need to override ButtonPressed(). This means the base class has to manually check for an owner.
Also, the theme infobar was erroneously returning true from Cancel() even though it was already closing. This led to RemoveSelf() being called twice. I fixed this and also put a defensive check in RemoveSelf() with a long comment about why it's there.
BUG=98691
TEST=none
Review URL: http://codereview.chromium.org/8093008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103576 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/metrics/metrics_log_serializer.h')
0 files changed, 0 insertions, 0 deletions