diff options
author | mukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-20 16:56:03 +0000 |
---|---|---|
committer | mukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-20 16:56:03 +0000 |
commit | 332d17d2d2889750fd87da90c2d9a796163e981c (patch) | |
tree | 584667b51d7aa63b058606adc8027946ead2046f /chrome/browser/metrics/omnibox_metrics_provider.cc | |
parent | ac8a16bc1ec072211e6e24a781d0bfd19c6ad9b8 (diff) | |
download | chromium_src-332d17d2d2889750fd87da90c2d9a796163e981c.zip chromium_src-332d17d2d2889750fd87da90c2d9a796163e981c.tar.gz chromium_src-332d17d2d2889750fd87da90c2d9a796163e981c.tar.bz2 |
Remove AutocompleteInput Type and PageClassification.
They are just as same as the enums defined in .proto files. Removing
the declaration of these types reduces unnecessary code dependency
to autocomplete.
BUG=384232
R=blundell@chromium.org, mpearson@chromium.org, pkasting@chromium.org
TBR=brettw@chromium.org, cpu@chromium.org, miguelg@chromium.org, mpcomplete@chromium.org
TEST=compile succeeds
Review URL: https://codereview.chromium.org/343523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278722 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/metrics/omnibox_metrics_provider.cc')
-rw-r--r-- | chrome/browser/metrics/omnibox_metrics_provider.cc | 31 |
1 files changed, 1 insertions, 30 deletions
diff --git a/chrome/browser/metrics/omnibox_metrics_provider.cc b/chrome/browser/metrics/omnibox_metrics_provider.cc index 2b99217..48fa3eb 100644 --- a/chrome/browser/metrics/omnibox_metrics_provider.cc +++ b/chrome/browser/metrics/omnibox_metrics_provider.cc @@ -9,7 +9,6 @@ #include "base/logging.h" #include "base/strings/string16.h" #include "base/strings/string_util.h" -#include "chrome/browser/autocomplete/autocomplete_input.h" #include "chrome/browser/autocomplete/autocomplete_match.h" #include "chrome/browser/autocomplete/autocomplete_provider.h" #include "chrome/browser/autocomplete/autocomplete_result.h" @@ -72,34 +71,6 @@ OmniboxEventProto::Suggestion::ResultType AsOmniboxEventResultType( return OmniboxEventProto::Suggestion::UNKNOWN_RESULT_TYPE; } -OmniboxEventProto::PageClassification AsOmniboxEventPageClassification( - AutocompleteInput::PageClassification page_classification) { - switch (page_classification) { - case AutocompleteInput::INVALID_SPEC: - return OmniboxEventProto::INVALID_SPEC; - case AutocompleteInput::NTP: - return OmniboxEventProto::NTP; - case AutocompleteInput::BLANK: - return OmniboxEventProto::BLANK; - case AutocompleteInput::HOME_PAGE: - return OmniboxEventProto::HOME_PAGE; - case AutocompleteInput::OTHER: - return OmniboxEventProto::OTHER; - case AutocompleteInput::SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT: - return OmniboxEventProto:: - SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT; - case AutocompleteInput::INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS: - return OmniboxEventProto::INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS; - case AutocompleteInput::INSTANT_NTP_WITH_FAKEBOX_AS_STARTING_FOCUS: - return OmniboxEventProto::INSTANT_NTP_WITH_FAKEBOX_AS_STARTING_FOCUS; - case AutocompleteInput::SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT: - return OmniboxEventProto:: - SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT; - } - NOTREACHED(); - return OmniboxEventProto::INVALID_SPEC; -} - } // namespace OmniboxMetricsProvider::OmniboxMetricsProvider() { @@ -167,7 +138,7 @@ void OmniboxMetricsProvider::RecordOmniboxOpenedURL(const OmniboxLog& log) { log.elapsed_time_since_last_change_to_default_match.InMilliseconds()); } omnibox_event->set_current_page_classification( - AsOmniboxEventPageClassification(log.current_page_classification)); + log.current_page_classification); omnibox_event->set_input_type(log.input_type); // We consider a paste-and-search/paste-and-go action to have a closed popup // (as explained in omnibox_event.proto) even if it was not, because such |