diff options
| author | brettw <brettw@chromium.org> | 2015-07-21 14:37:38 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-21 21:38:12 +0000 |
| commit | c6f82b158f374c172a46326699f03d97777faa8e (patch) | |
| tree | c96472fa185ca20b22fad773cd195689e4097894 /chrome/browser/metrics/thread_watcher_unittest.cc | |
| parent | db484c3eff68c46ddf1530dd60441dba4614cb5c (diff) | |
| download | chromium_src-c6f82b158f374c172a46326699f03d97777faa8e.zip chromium_src-c6f82b158f374c172a46326699f03d97777faa8e.tar.gz chromium_src-c6f82b158f374c172a46326699f03d97777faa8e.tar.bz2 | |
Update SplitString calls in chrome.
In many places that iterated over the results, the code was changed to use a range-based for loop over the result of the SplitStirng call.
Review URL: https://codereview.chromium.org/1240183002
Cr-Commit-Position: refs/heads/master@{#339753}
Diffstat (limited to 'chrome/browser/metrics/thread_watcher_unittest.cc')
| -rw-r--r-- | chrome/browser/metrics/thread_watcher_unittest.cc | 21 |
1 files changed, 9 insertions, 12 deletions
diff --git a/chrome/browser/metrics/thread_watcher_unittest.cc b/chrome/browser/metrics/thread_watcher_unittest.cc index 464dbfd..15d6d40 100644 --- a/chrome/browser/metrics/thread_watcher_unittest.cc +++ b/chrome/browser/metrics/thread_watcher_unittest.cc @@ -352,11 +352,10 @@ TEST_F(ThreadWatcherTest, ThreadNamesOnlyArgs) { // Verify the data. base::StringTokenizer tokens(crash_on_hang_thread_names, ","); - std::vector<std::string> values; while (tokens.GetNext()) { - const std::string& token = tokens.token(); - base::SplitString(token, ':', &values); - std::string thread_name = values[0]; + std::vector<base::StringPiece> values = base::SplitStringPiece( + tokens.token_piece(), ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); + std::string thread_name = values[0].as_string(); ThreadWatcherList::CrashOnHangThreadMap::iterator it = crash_on_hang_threads.find(thread_name); @@ -382,11 +381,10 @@ TEST_F(ThreadWatcherTest, ThreadNamesAndLiveThresholdArgs) { // Verify the data. base::StringTokenizer tokens(thread_names_and_live_threshold, ","); - std::vector<std::string> values; while (tokens.GetNext()) { - const std::string& token = tokens.token(); - base::SplitString(token, ':', &values); - std::string thread_name = values[0]; + std::vector<base::StringPiece> values = base::SplitStringPiece( + tokens.token_piece(), ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); + std::string thread_name = values[0].as_string(); ThreadWatcherList::CrashOnHangThreadMap::iterator it = crash_on_hang_threads.find(thread_name); @@ -412,11 +410,10 @@ TEST_F(ThreadWatcherTest, CrashOnHangThreadsAllArgs) { // Verify the data. base::StringTokenizer tokens(crash_on_hang_thread_data, ","); - std::vector<std::string> values; while (tokens.GetNext()) { - const std::string& token = tokens.token(); - base::SplitString(token, ':', &values); - std::string thread_name = values[0]; + std::vector<base::StringPiece> values = base::SplitStringPiece( + tokens.token_piece(), ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); + std::string thread_name = values[0].as_string(); ThreadWatcherList::CrashOnHangThreadMap::iterator it = crash_on_hang_threads.find(thread_name); |