diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-13 23:18:02 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-13 23:18:02 +0000 |
| commit | 235caa47af34c2f68b26a38d46f1002e56f6cbfe (patch) | |
| tree | 0c9394d1337957754d93b1a7c8ca54809f996fae /chrome/browser/metrics | |
| parent | e9d2f166c90ccd612c7ba014c4066840053d5bee (diff) | |
| download | chromium_src-235caa47af34c2f68b26a38d46f1002e56f6cbfe.zip chromium_src-235caa47af34c2f68b26a38d46f1002e56f6cbfe.tar.gz chromium_src-235caa47af34c2f68b26a38d46f1002e56f6cbfe.tar.bz2 | |
Don't overload the meaning of the RENDERER_PROCESS_TERMINATED notification, instead create a new one for crashing.
The old way of using notifications was incorrect since a RenderProcessHost might have sent only one notification even though a new renderer might have been created after a crash.
BUG=9379
Review URL: http://codereview.chromium.org/66069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13629 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/metrics')
| -rw-r--r-- | chrome/browser/metrics/metrics_service.cc | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc index 2d5b502..1e447ea 100644 --- a/chrome/browser/metrics/metrics_service.cc +++ b/chrome/browser/metrics/metrics_service.cc @@ -507,9 +507,8 @@ void MetricsService::Observe(NotificationType type, LogLoadStarted(); break; - case NotificationType::RENDERER_PROCESS_TERMINATED: - if (!*Details<bool>(details).ptr()) - LogRendererCrash(); + case NotificationType::RENDERER_PROCESS_CRASHED: + LogRendererCrash(); break; case NotificationType::RENDERER_PROCESS_HANG: @@ -792,7 +791,7 @@ void MetricsService::ListenerRegistration(bool start_listening) { AddOrRemoveObserver(this, NotificationType::LOAD_STOP, start_listening); AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_IN_SBOX, start_listening); - AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_TERMINATED, + AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_CRASHED, start_listening); AddOrRemoveObserver(this, NotificationType::RENDERER_PROCESS_HANG, start_listening); |