diff options
author | stoyan@chromium.org <stoyan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-28 19:12:46 +0000 |
---|---|---|
committer | stoyan@chromium.org <stoyan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-28 19:12:46 +0000 |
commit | 802376eb9aacca5284b76da93face73a9488bdb6 (patch) | |
tree | 705226a6750fed9a1429aaf07fe9c0a03303c759 /chrome/browser/metrics | |
parent | 319d4ae6c8b2236fa7e0acf218c533a5a93af5a6 (diff) | |
download | chromium_src-802376eb9aacca5284b76da93face73a9488bdb6.zip chromium_src-802376eb9aacca5284b76da93face73a9488bdb6.tar.gz chromium_src-802376eb9aacca5284b76da93face73a9488bdb6.tar.bz2 |
Make automation proxy objects to ref_counted. That allows to process async notifications directly in channel background thread. Add support for listener-less ChannelProxy.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113722
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/metrics')
-rw-r--r-- | chrome/browser/metrics/metrics_service_uitest.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/metrics/metrics_service_uitest.cc b/chrome/browser/metrics/metrics_service_uitest.cc index 9f208f0..7245a35 100644 --- a/chrome/browser/metrics/metrics_service_uitest.cc +++ b/chrome/browser/metrics/metrics_service_uitest.cc @@ -24,7 +24,7 @@ class MetricsServiceTest : public UITest { public: - MetricsServiceTest() : UITest(), window_(NULL) { + MetricsServiceTest() : UITest() { // We need to show the window so web content type tabs load. show_window_ = true; } @@ -32,7 +32,7 @@ class MetricsServiceTest : public UITest { // Open a few tabs of random content void OpenTabs() { window_ = automation()->GetBrowserWindow(0); - ASSERT_TRUE(window_); + ASSERT_TRUE(window_.get()); FilePath page1_path; ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &page1_path)); @@ -57,12 +57,12 @@ class MetricsServiceTest : public UITest { } virtual void TearDown() { - delete window_; + window_ = NULL; UITest::TearDown(); } protected: - BrowserProxy* window_; + scoped_refptr<BrowserProxy> window_; }; TEST_F(MetricsServiceTest, CloseRenderersNormally) { @@ -88,7 +88,7 @@ TEST_F(MetricsServiceTest, CrashRenderers) { OpenTabs(); // kill the process for one of the tabs - scoped_ptr<TabProxy> tab(window_->GetTab(1)); + scoped_refptr<TabProxy> tab(window_->GetTab(1)); ASSERT_TRUE(tab.get()); int process_id = 0; ASSERT_TRUE(tab->GetProcessID(&process_id)); |