diff options
| author | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-04 16:46:48 +0000 |
|---|---|---|
| committer | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-04 16:46:48 +0000 |
| commit | fd37bf65c63bced08f6ca7e70a8aad5e2ba6bbbb (patch) | |
| tree | 638dc2ece5a78774910f1499b5e4faba7dff67b6 /chrome/browser/nacl_host/nacl_broker_service_win.h | |
| parent | 894a34f3e5298a2a73cc4ff0bc5360900596fb5a (diff) | |
| download | chromium_src-fd37bf65c63bced08f6ca7e70a8aad5e2ba6bbbb.zip chromium_src-fd37bf65c63bced08f6ca7e70a8aad5e2ba6bbbb.tar.gz chromium_src-fd37bf65c63bced08f6ca7e70a8aad5e2ba6bbbb.tar.bz2 | |
NaCl: Pass process info through to the Windows debug exception handler
This removes the assumption that NaCl's data structures are located at
the same addresses in the debugger and debuggee processes, because we
pass the addresses of the data structures through IPC instead.
This fixes the debug exception handler to work in cases where
chrome.dll or nacl64.exe get relocated, which tends to happen for
chrome.dll on Windows XP. (However, since there are no trybots for
32-bit Windows, I will enable the test on 32-bit Windows in a separate
change.)
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2695
TEST=run_inbrowser_exception_test in nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10351016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135361 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/nacl_host/nacl_broker_service_win.h')
| -rw-r--r-- | chrome/browser/nacl_host/nacl_broker_service_win.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/nacl_host/nacl_broker_service_win.h b/chrome/browser/nacl_host/nacl_broker_service_win.h index 82c9816..8323cdd 100644 --- a/chrome/browser/nacl_host/nacl_broker_service_win.h +++ b/chrome/browser/nacl_host/nacl_broker_service_win.h @@ -37,7 +37,8 @@ class NaClBrokerService { bool LaunchDebugExceptionHandler(base::WeakPtr<NaClProcessHost> client, int32 pid, - base::ProcessHandle process_handle); + base::ProcessHandle process_handle, + const std::string& startup_info); // Called by NaClBrokerHost to notify the service that a debug // exception handler was started. |