summaryrefslogtreecommitdiffstats
path: root/chrome/browser/net
diff options
context:
space:
mode:
authorthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-01 04:16:27 +0000
committerthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-01 04:16:27 +0000
commitad8e04ac88be37d5ccb6c2cf61f52b224dca493c (patch)
tree9bcb878643bdd9e5af6749fff469b2552e569907 /chrome/browser/net
parent5af8043eb24ad60251d8a4e33192e3e6f59246a3 (diff)
downloadchromium_src-ad8e04ac88be37d5ccb6c2cf61f52b224dca493c.zip
chromium_src-ad8e04ac88be37d5ccb6c2cf61f52b224dca493c.tar.gz
chromium_src-ad8e04ac88be37d5ccb6c2cf61f52b224dca493c.tar.bz2
Convert implicit scoped_refptr constructor calls to explicit ones, part 1
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/net')
-rw-r--r--chrome/browser/net/connection_tester.cc8
-rw-r--r--chrome/browser/net/connection_tester_unittest.cc4
-rw-r--r--chrome/browser/net/predictor_unittest.cc36
-rw-r--r--chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc4
4 files changed, 26 insertions, 26 deletions
diff --git a/chrome/browser/net/connection_tester.cc b/chrome/browser/net/connection_tester.cc
index 889494d..8f762ef 100644
--- a/chrome/browser/net/connection_tester.cc
+++ b/chrome/browser/net/connection_tester.cc
@@ -277,8 +277,8 @@ void ConnectionTester::TestRunner::OnReadCompleted(URLRequest* request,
void ConnectionTester::TestRunner::ReadBody(URLRequest* request) {
// Read the response body |kReadBufferSize| bytes at a time.
- scoped_refptr<net::IOBuffer> unused_buffer =
- new net::IOBuffer(kReadBufferSize);
+ scoped_refptr<net::IOBuffer> unused_buffer(
+ new net::IOBuffer(kReadBufferSize));
int num_bytes;
if (request->Read(unused_buffer, kReadBufferSize, &num_bytes)) {
OnReadCompleted(request, num_bytes);
@@ -299,8 +299,8 @@ void ConnectionTester::TestRunner::OnResponseCompleted(URLRequest* request) {
void ConnectionTester::TestRunner::Run(const Experiment& experiment) {
// Try to create a URLRequestContext for this experiment.
- scoped_refptr<ExperimentURLRequestContext> context =
- new ExperimentURLRequestContext(tester_->io_thread_);
+ scoped_refptr<ExperimentURLRequestContext> context(
+ new ExperimentURLRequestContext(tester_->io_thread_));
int rv = context->Init(experiment);
if (rv != net::OK) {
// Complete the experiment with a failure.
diff --git a/chrome/browser/net/connection_tester_unittest.cc b/chrome/browser/net/connection_tester_unittest.cc
index fe6e8cc..4191484 100644
--- a/chrome/browser/net/connection_tester_unittest.cc
+++ b/chrome/browser/net/connection_tester_unittest.cc
@@ -76,8 +76,8 @@ class ConnectionTesterTest : public PlatformTest {
: test_server_(net::TestServer::TYPE_HTTP,
FilePath(FILE_PATH_LITERAL("net/data/url_request_unittest"))),
message_loop_(MessageLoop::TYPE_IO) {
- scoped_refptr<net::RuleBasedHostResolverProc> catchall_resolver =
- new net::RuleBasedHostResolverProc(NULL);
+ scoped_refptr<net::RuleBasedHostResolverProc> catchall_resolver(
+ new net::RuleBasedHostResolverProc(NULL));
catchall_resolver->AddRule("*", "127.0.0.1");
diff --git a/chrome/browser/net/predictor_unittest.cc b/chrome/browser/net/predictor_unittest.cc
index 38f0281..bbc798e 100644
--- a/chrome/browser/net/predictor_unittest.cc
+++ b/chrome/browser/net/predictor_unittest.cc
@@ -109,25 +109,25 @@ class PredictorTest : public testing::Test {
//------------------------------------------------------------------------------
TEST_F(PredictorTest, StartupShutdownTest) {
- scoped_refptr<Predictor> testing_master =
+ scoped_refptr<Predictor> testing_master(
new Predictor(host_resolver_.get(),
default_max_queueing_delay_,
PredictorInit::kMaxSpeculativeParallelResolves,
- false);
+ false));
testing_master->Shutdown();
}
TEST_F(PredictorTest, ShutdownWhenResolutionIsPendingTest) {
- scoped_refptr<net::WaitingHostResolverProc> resolver_proc =
- new net::WaitingHostResolverProc(NULL);
+ scoped_refptr<net::WaitingHostResolverProc> resolver_proc(
+ new net::WaitingHostResolverProc(NULL));
host_resolver_->Reset(resolver_proc);
- scoped_refptr<Predictor> testing_master =
+ scoped_refptr<Predictor> testing_master(
new Predictor(host_resolver_.get(),
default_max_queueing_delay_,
PredictorInit::kMaxSpeculativeParallelResolves,
- false);
+ false));
GURL localhost("http://localhost:80");
UrlList names;
@@ -149,11 +149,11 @@ TEST_F(PredictorTest, ShutdownWhenResolutionIsPendingTest) {
}
TEST_F(PredictorTest, SingleLookupTest) {
- scoped_refptr<Predictor> testing_master =
+ scoped_refptr<Predictor> testing_master(
new Predictor(host_resolver_.get(),
default_max_queueing_delay_,
PredictorInit::kMaxSpeculativeParallelResolves,
- false);
+ false));
GURL goog("http://www.google.com:80");
@@ -181,11 +181,11 @@ TEST_F(PredictorTest, SingleLookupTest) {
TEST_F(PredictorTest, ConcurrentLookupTest) {
host_resolver_->rules()->AddSimulatedFailure("*.notfound");
- scoped_refptr<Predictor> testing_master =
+ scoped_refptr<Predictor> testing_master(
new Predictor(host_resolver_.get(),
default_max_queueing_delay_,
PredictorInit::kMaxSpeculativeParallelResolves,
- false);
+ false));
GURL goog("http://www.google.com:80"),
goog2("http://gmail.google.com.com:80"),
@@ -231,11 +231,11 @@ TEST_F(PredictorTest, ConcurrentLookupTest) {
TEST_F(PredictorTest, MassiveConcurrentLookupTest) {
host_resolver_->rules()->AddSimulatedFailure("*.notfound");
- scoped_refptr<Predictor> testing_master =
+ scoped_refptr<Predictor> testing_master(
new Predictor(host_resolver_.get(),
default_max_queueing_delay_,
PredictorInit::kMaxSpeculativeParallelResolves,
- false);
+ false));
UrlList names;
for (int i = 0; i < 100; i++)
@@ -351,11 +351,11 @@ static bool GetDataFromSerialization(const GURL& motivation,
// Make sure nil referral lists really have no entries, and no latency listed.
TEST_F(PredictorTest, ReferrerSerializationNilTest) {
- scoped_refptr<Predictor> predictor =
+ scoped_refptr<Predictor> predictor(
new Predictor(host_resolver_.get(),
default_max_queueing_delay_,
PredictorInit::kMaxSpeculativeParallelResolves,
- false);
+ false));
scoped_ptr<ListValue> referral_list(NewEmptySerializationList());
predictor->SerializeReferrers(referral_list.get());
EXPECT_EQ(1U, referral_list->GetSize());
@@ -370,11 +370,11 @@ TEST_F(PredictorTest, ReferrerSerializationNilTest) {
// deserialized into the database, and can be extracted back out via
// serialization without being changed.
TEST_F(PredictorTest, ReferrerSerializationSingleReferrerTest) {
- scoped_refptr<Predictor> predictor =
+ scoped_refptr<Predictor> predictor(
new Predictor(host_resolver_.get(),
default_max_queueing_delay_,
PredictorInit::kMaxSpeculativeParallelResolves,
- false);
+ false));
const GURL motivation_url("http://www.google.com:91");
const GURL subresource_url("http://icons.google.com:90");
const double kUseRate = 23.4;
@@ -398,11 +398,11 @@ TEST_F(PredictorTest, ReferrerSerializationSingleReferrerTest) {
// Make sure the Trim() functionality works as expected.
TEST_F(PredictorTest, ReferrerSerializationTrimTest) {
- scoped_refptr<Predictor> predictor =
+ scoped_refptr<Predictor> predictor(
new Predictor(host_resolver_.get(),
default_max_queueing_delay_,
PredictorInit::kMaxSpeculativeParallelResolves,
- false);
+ false));
GURL motivation_url("http://www.google.com:110");
GURL icon_subresource_url("http://icons.google.com:111");
diff --git a/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc b/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
index 9c0ab55..fd5088b 100644
--- a/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
+++ b/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
@@ -28,8 +28,8 @@ static scoped_refptr<WebSocketExperimentRunner> runner;
void WebSocketExperimentRunner::Start() {
DCHECK(!runner.get());
- scoped_refptr<base::FieldTrial> trial =
- new base::FieldTrial("WebSocketExperiment", 1000);
+ scoped_refptr<base::FieldTrial> trial(
+ new base::FieldTrial("WebSocketExperiment", 1000));
trial->AppendGroup("active", 5); // 0.5% in active group.
bool run_experiment =