diff options
| author | dharcourt@chromium.org <dharcourt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-08 03:55:38 +0000 |
|---|---|---|
| committer | dharcourt@chromium.org <dharcourt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-08 03:55:38 +0000 |
| commit | 73662cf81ff77c832db42eea71a3d6affed75f67 (patch) | |
| tree | 0771461a941d4ff1993e94ba0b979103c3b262fd /chrome/browser/notifications/message_center_notification_manager.cc | |
| parent | 2a98f90a3637e932db7db5da634b169f6553ac11 (diff) | |
| download | chromium_src-73662cf81ff77c832db42eea71a3d6affed75f67.zip chromium_src-73662cf81ff77c832db42eea71a3d6affed75f67.tar.gz chromium_src-73662cf81ff77c832db42eea71a3d6affed75f67.tar.bz2 | |
Made notification center notifications collapsible and expandable.
Implemented collapse/expand for notifications in the notification
center. Notifications are collapsed by default and can be expanded by
pressing their expand button. Once expanded, they can't be collapsed
again.
Limitations of this version are:
1) Notifications in alerts/toasts are not affected (they're always expanded).
2) Notifications get expand buttons even if they have no content to expand.
3) Collapsed text is always collapsed to 1 lines (not 2 or 3 as required) and expanded text
is always expanded to its full height (not limited to 7 lines as
required).
4) Notification expansion is lost when notifications are
added to the notification center or when the notification center is
closed and opened again. These issues will be addressed in separate
change lists.
BUG=161098
TBR=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12326091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186873 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/notifications/message_center_notification_manager.cc')
| -rw-r--r-- | chrome/browser/notifications/message_center_notification_manager.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/notifications/message_center_notification_manager.cc b/chrome/browser/notifications/message_center_notification_manager.cc index 347f26b..38d1995 100644 --- a/chrome/browser/notifications/message_center_notification_manager.cc +++ b/chrome/browser/notifications/message_center_notification_manager.cc @@ -141,7 +141,7 @@ bool MessageCenterNotificationManager::UpdateNotification( old_notification->profile()->IsSameProfile(profile)) { std::string old_id = old_notification->notification().notification_id(); - DCHECK(message_center_->GetNotificationList()->HasNotification(old_id)); + DCHECK(message_center_->notification_list()->HasNotification(old_id)); // Add/remove notification in the local list but just update the same // one in MessageCenter. |