diff options
| author | cmp@chromium.org <cmp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-07 20:42:34 +0000 |
|---|---|---|
| committer | cmp@chromium.org <cmp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-07 20:42:34 +0000 |
| commit | c3753652dcda5056fe98d6b54296302977adac40 (patch) | |
| tree | 35b987d86f8ba86a4391122a534d36f2532b2743 /chrome/browser/omnibox_search_hint.cc | |
| parent | a43c44973af60e8bd003ae1595d333c154d9bf26 (diff) | |
| download | chromium_src-c3753652dcda5056fe98d6b54296302977adac40.zip chromium_src-c3753652dcda5056fe98d6b54296302977adac40.tar.gz chromium_src-c3753652dcda5056fe98d6b54296302977adac40.tar.bz2 | |
Revert 89864 - Don't rely on user gestures for deciding when to dismiss infobars.
Previously, we looked at the user gesture state when deciding whether to
dismiss infobars. Now that WebKit's user gesture state doesn't lie, we can
tell that this behavior is incorrect. Page-specific infobars, like translate,
should close whenever the main frame navigates to a new page, regardless of
whether that navigation was conducted from a user gesture.
BUG=86417
Review URL: http://codereview.chromium.org/7205026
TBR=abarth@chromium.org
Review URL: http://codereview.chromium.org/7324001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91744 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/omnibox_search_hint.cc')
| -rw-r--r-- | chrome/browser/omnibox_search_hint.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/omnibox_search_hint.cc b/chrome/browser/omnibox_search_hint.cc index a5b8918a..2e04a3b 100644 --- a/chrome/browser/omnibox_search_hint.cc +++ b/chrome/browser/omnibox_search_hint.cc @@ -102,7 +102,7 @@ HintInfoBar::~HintInfoBar() { bool HintInfoBar::ShouldExpire( const content::LoadCommittedDetails& details) const { - return details.is_navigation_to_different_page() && should_expire_; + return details.is_user_initiated_main_frame_load() && should_expire_; } void HintInfoBar::InfoBarDismissed() { |