diff options
author | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-16 19:36:16 +0000 |
---|---|---|
committer | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-16 19:36:16 +0000 |
commit | e768baf6ebf5a49cc19d58d1761321b175c82c18 (patch) | |
tree | c29fb1ebcef46d9ad929ed1fd68f954a04f97b06 /chrome/browser/password_manager/password_manager_unittest.cc | |
parent | a850e9592bb1a8c43275116ff565c91b4b1cb66b (diff) | |
download | chromium_src-e768baf6ebf5a49cc19d58d1761321b175c82c18.zip chromium_src-e768baf6ebf5a49cc19d58d1761321b175c82c18.tar.gz chromium_src-e768baf6ebf5a49cc19d58d1761321b175c82c18.tar.bz2 |
Separate the PasswordManagerDelegate out of PasswordManager.
Previously, anyone who included tab_contents.h would bring in a bunch of
implementation details of the password manager from webkit_glue. This breaks
the delegate interface out of the rest of password manager system and makes
FillData not an inner-class so anyone can forward declare FillData instead of
having to include the header to meet a delegate interface.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2877022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52726 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/password_manager/password_manager_unittest.cc')
-rw-r--r-- | chrome/browser/password_manager/password_manager_unittest.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/browser/password_manager/password_manager_unittest.cc b/chrome/browser/password_manager/password_manager_unittest.cc index e8430f7..9f5acc3 100644 --- a/chrome/browser/password_manager/password_manager_unittest.cc +++ b/chrome/browser/password_manager/password_manager_unittest.cc @@ -5,6 +5,7 @@ #include "base/file_path.h" #include "base/string_util.h" #include "chrome/browser/password_manager/password_manager.h" +#include "chrome/browser/password_manager/password_manager_delegate.h" #include "chrome/browser/password_manager/password_store.h" #include "chrome/browser/pref_service.h" #include "chrome/common/url_constants.h" @@ -19,10 +20,10 @@ using ::testing::Exactly; using ::testing::WithArg; using ::testing::Return; -class MockPasswordManagerDelegate : public PasswordManager::Delegate { +class MockPasswordManagerDelegate : public PasswordManagerDelegate { public: MOCK_METHOD1(FillPasswordForm, void( - const webkit_glue::PasswordFormDomManager::FillData&)); + const webkit_glue::PasswordFormFillData&)); MOCK_METHOD1(AddSavePasswordInfoBar, void(PasswordFormManager*)); MOCK_METHOD0(GetProfileForPasswordManager, Profile*()); MOCK_METHOD0(DidLastPageLoadEncounterSSLErrors, bool()); |