summaryrefslogtreecommitdiffstats
path: root/chrome/browser/password_manager
diff options
context:
space:
mode:
authorrsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-18 18:00:22 +0000
committerrsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-18 18:00:22 +0000
commit4e0f45f5cc4911b529040c82058b255049426e93 (patch)
tree6535c84613ab4f672f08b27d2b2d36cffa4bce92 /chrome/browser/password_manager
parentf7d2580cf40718cb427f8587e9f1f6f6f837ba39 (diff)
downloadchromium_src-4e0f45f5cc4911b529040c82058b255049426e93.zip
chromium_src-4e0f45f5cc4911b529040c82058b255049426e93.tar.gz
chromium_src-4e0f45f5cc4911b529040c82058b255049426e93.tar.bz2
RefCounted types should not have public destructors, Linux fixes
BUG=123295 TEST=none Review URL: https://chromiumcodereview.appspot.com/10392152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137893 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/password_manager')
-rw-r--r--chrome/browser/password_manager/password_store_default_unittest.cc13
-rw-r--r--chrome/browser/password_manager/password_store_x_unittest.cc13
2 files changed, 14 insertions, 12 deletions
diff --git a/chrome/browser/password_manager/password_store_default_unittest.cc b/chrome/browser/password_manager/password_store_default_unittest.cc
index e1f3ba1..9eb297e 100644
--- a/chrome/browser/password_manager/password_store_default_unittest.cc
+++ b/chrome/browser/password_manager/password_store_default_unittest.cc
@@ -64,17 +64,18 @@ class DBThreadObserverHelper
done_event_.Wait();
}
- virtual ~DBThreadObserverHelper() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
- registrar_.RemoveAll();
- }
-
content::NotificationObserverMock& observer() {
return observer_;
}
protected:
- friend class base::RefCountedThreadSafe<DBThreadObserverHelper>;
+ friend struct BrowserThread::DeleteOnThread<BrowserThread::DB>;
+ friend class base::DeleteHelper<DBThreadObserverHelper>;
+
+ virtual ~DBThreadObserverHelper() {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
+ registrar_.RemoveAll();
+ }
void AddObserverTask(PasswordStore* password_store) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
diff --git a/chrome/browser/password_manager/password_store_x_unittest.cc b/chrome/browser/password_manager/password_store_x_unittest.cc
index e9f33a2..29ff1c7 100644
--- a/chrome/browser/password_manager/password_store_x_unittest.cc
+++ b/chrome/browser/password_manager/password_store_x_unittest.cc
@@ -70,17 +70,18 @@ class DBThreadObserverHelper
done_event_.Wait();
}
- virtual ~DBThreadObserverHelper() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
- registrar_.RemoveAll();
- }
-
content::NotificationObserverMock& observer() {
return observer_;
}
protected:
- friend class base::RefCountedThreadSafe<DBThreadObserverHelper>;
+ friend struct BrowserThread::DeleteOnThread<BrowserThread::DB>;
+ friend class base::DeleteHelper<DBThreadObserverHelper>;
+
+ virtual ~DBThreadObserverHelper() {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
+ registrar_.RemoveAll();
+ }
void AddObserverTask(PasswordStore* password_store) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));