diff options
author | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-14 13:07:11 +0000 |
---|---|---|
committer | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-14 13:07:11 +0000 |
commit | e77cfe45dc7dae8d35f9d1de9a4a27df547a368f (patch) | |
tree | 2ce650c3bb8b52c484e0903e0c33b02ced018382 /chrome/browser/pepper_flash_settings_manager.cc | |
parent | 5288b8ea4bdac51d7bc4298af6cb7e1d27e924aa (diff) | |
download | chromium_src-e77cfe45dc7dae8d35f9d1de9a4a27df547a368f.zip chromium_src-e77cfe45dc7dae8d35f9d1de9a4a27df547a368f.tar.gz chromium_src-e77cfe45dc7dae8d35f9d1de9a4a27df547a368f.tar.bz2 |
Revert 167589 - Continuing TODO items from a previous CL, remove the "extra_field" and "second_extra_field" keys from the API and replace with real keys from the Base Format View spec. Implement a rough layout that resembles the expanded mode of the view.
Breaks win_aura, I guess you need to add a dependency on base.gyp:base_i18n
Outstanding items:
- As stated above, the layout is still ugly.
- We don't gracefully handle empty buttons. We don't crash, either, but it looks even uglier when the buttons are missing.
- The buttons don't do anything when the user clicks on them.
- The second icon is just a redraw of the first.
- The timestamp is hardcoded to "10:43 AM" for layout purposes. I need to do more research on the appropriate date-formatting facilities available to us, and from that back out the timestamp field format in the API itself.
Review URL: https://chromiumcodereview.appspot.com/11358144
TBR=miket@chromium.org
Review URL: https://codereview.chromium.org/11377156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167662 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/pepper_flash_settings_manager.cc')
0 files changed, 0 insertions, 0 deletions