summaryrefslogtreecommitdiffstats
path: root/chrome/browser/policy/cloud/device_management_service_unittest.cc
diff options
context:
space:
mode:
authordcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-09 05:45:17 +0000
committerdcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-09 05:45:17 +0000
commite59558b78e8c6a1b0bd916a724724b638c3c91b6 (patch)
tree712268a7e9e1cd552f309d89641b2bed5ad06322 /chrome/browser/policy/cloud/device_management_service_unittest.cc
parent31fcd34da3797bc49160620ef8c94a38652c0587 (diff)
downloadchromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.zip
chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.gz
chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.bz2
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/policy/cloud/device_management_service_unittest.cc')
-rw-r--r--chrome/browser/policy/cloud/device_management_service_unittest.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/policy/cloud/device_management_service_unittest.cc b/chrome/browser/policy/cloud/device_management_service_unittest.cc
index ae84965..b83ca80 100644
--- a/chrome/browser/policy/cloud/device_management_service_unittest.cc
+++ b/chrome/browser/policy/cloud/device_management_service_unittest.cc
@@ -513,7 +513,7 @@ TEST_F(DeviceManagementServiceTest, CancelDuringCallback) {
// Generate a callback.
net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
- SendResponse(fetcher, status, 500, "");
+ SendResponse(fetcher, status, 500, std::string());
// Job should have been reset.
EXPECT_FALSE(request_job.get());
@@ -534,7 +534,7 @@ TEST_F(DeviceManagementServiceTest, RetryOnProxyError) {
// Generate a callback with a proxy failure.
net::URLRequestStatus status(net::URLRequestStatus::FAILED,
net::ERR_PROXY_CONNECTION_FAILED);
- SendResponse(fetcher, status, 200, "");
+ SendResponse(fetcher, status, 200, std::string());
// Verify that a new URLFetcher was started that bypasses the proxy.
fetcher = GetFetcher();
@@ -564,7 +564,7 @@ TEST_F(DeviceManagementServiceTest, RetryOnBadResponseFromProxy) {
// Generate a callback with a valid http response, that was generated by
// a bad/wrong proxy.
net::URLRequestStatus status;
- SendResponse(fetcher, status, 200, "");
+ SendResponse(fetcher, status, 200, std::string());
// Verify that a new URLFetcher was started that bypasses the proxy.
fetcher = GetFetcher();