summaryrefslogtreecommitdiffstats
path: root/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc
diff options
context:
space:
mode:
authorestade <estade@chromium.org>2015-05-22 09:30:13 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-22 16:30:52 +0000
commitb09312bb5ad1bffaad8a09deea395f1aef2053df (patch)
treeea13602ed858503180cd725d1afe6a4ce73a2bd9 /chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc
parent2d381b0799c9fbbd33fbfa5ccf6610794d454f71 (diff)
downloadchromium_src-b09312bb5ad1bffaad8a09deea395f1aef2053df.zip
chromium_src-b09312bb5ad1bffaad8a09deea395f1aef2053df.tar.gz
chromium_src-b09312bb5ad1bffaad8a09deea395f1aef2053df.tar.bz2
Use scoped_ptrs in JSONReader::Read functions.
There are many callers, so all could not be updated at once. The old version is renamed to JSONReader::DeprecatedRead, and a new version of JSONReader::Read that returns scoped_ptr takes its place. Much of this patch was generated with sed. Some callsites of the form scoped_ptr<Value> value(Read()); have been updated to scoped_ptr<Value> value = Read(); but most Read() calls are simply converted to DeprecatedRead. Actually updating them is a TODO. BUG=none Review URL: https://codereview.chromium.org/1136643005 Cr-Commit-Position: refs/heads/master@{#331120}
Diffstat (limited to 'chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc')
-rw-r--r--chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc18
1 files changed, 6 insertions, 12 deletions
diff --git a/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc b/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc
index 7737e71..b232f6e 100644
--- a/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc
+++ b/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc
@@ -31,10 +31,8 @@ TEST_F(ManagedBookmarksPolicyHandlerTest, ApplyPolicySettings) {
EXPECT_FALSE(store_->GetValue(bookmarks::prefs::kManagedBookmarks, NULL));
PolicyMap policy;
- policy.Set(key::kManagedBookmarks,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- base::JSONReader::Read(
+ policy.Set(key::kManagedBookmarks, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+ base::JSONReader::DeprecatedRead(
"["
" {"
" \"name\": \"Google\","
@@ -129,10 +127,8 @@ TEST_F(ManagedBookmarksPolicyHandlerTest, WrongPolicyType) {
#if defined(ENABLE_EXTENSIONS)
TEST_F(ManagedBookmarksPolicyHandlerTest, UnknownKeys) {
PolicyMap policy;
- policy.Set(key::kManagedBookmarks,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- base::JSONReader::Read(
+ policy.Set(key::kManagedBookmarks, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+ base::JSONReader::DeprecatedRead(
"["
" {"
" \"name\": \"Google\","
@@ -160,10 +156,8 @@ TEST_F(ManagedBookmarksPolicyHandlerTest, UnknownKeys) {
#if defined(ENABLE_EXTENSIONS)
TEST_F(ManagedBookmarksPolicyHandlerTest, BadBookmark) {
PolicyMap policy;
- policy.Set(key::kManagedBookmarks,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- base::JSONReader::Read(
+ policy.Set(key::kManagedBookmarks, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+ base::JSONReader::DeprecatedRead(
"["
" {"
" \"name\": \"Empty\","