Adjust preference sync code to only sync user modifiable preferences.

Switch to the new preference value source checkers in Preference. While at it,
add a unit test and better test infrastructure for controlling preference
values in tests. Convert existing unit tests where appropriate.

BUG=48952
TEST=ProfileSyncServicePreferenceTest.ManagedPreferences

Review URL: http://codereview.chromium.org/3051001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53179 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 11 insertions, 1 deletions

diff --git a/chrome/browser/pref_value_store.h b/chrome/browser/pref_value_store.h
index 885b7c0..9dcce64 100644
--- a/chrome/browser/pref_value_store.h
+++ b/chrome/browser/pref_value_store.h
@@ -96,9 +96,16 @@ class PrefValueStore {
   bool PrefValueFromExtensionStore(const wchar_t* name);
   bool PrefValueFromUserStore(const wchar_t* name);
 
+  // Check whether a Preference value is modifiable by the user, i.e. whether
+  // there is no higher-priority source controlling it.
+  bool PrefValueUserModifiable(const wchar_t* name);
+
  private:
   // PrefStores must be listed here in order from highest to lowest priority.
   enum PrefStoreType {
+    // Not associated with an actual PrefStore but used as invalid marker, e.g.
+    // as return value.
+    INVALID = -1,
     MANAGED = 0,
     EXTENSION,
     COMMAND_LINE,
@@ -111,7 +118,10 @@ class PrefValueStore {
 
   bool PrefValueInStore(const wchar_t* name, PrefStoreType type);
 
-  bool PrefValueFromStore(const wchar_t* name, PrefStoreType type);
+  // Returns the pref store type identifying the source that controls the
+  // Preference identified by |name|. If none of the sources has a value,
+  // INVALID is returned.
+  PrefStoreType ControllingPrefStoreForPref(const wchar_t* name);
 
   DISALLOW_COPY_AND_ASSIGN(PrefValueStore);
 };