summaryrefslogtreecommitdiffstats
path: root/chrome/browser/prefs/pref_service_syncable.h
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-10-23 09:37:48 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-23 16:38:05 +0000
commit8f4b862cd59d29d615929c5c66ca3fe749914cd0 (patch)
treeed406e472b20e42dd5bdc819d812ee2a9435f8eb /chrome/browser/prefs/pref_service_syncable.h
parentd28506ba1497a3f5fa5b9f6702892cb1cb58ea15 (diff)
downloadchromium_src-8f4b862cd59d29d615929c5c66ca3fe749914cd0.zip
chromium_src-8f4b862cd59d29d615929c5c66ca3fe749914cd0.tar.gz
chromium_src-8f4b862cd59d29d615929c5c66ca3fe749914cd0.tar.bz2
Standardize usage of virtual/override/final in chrome/browser/prefs
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=gab@chromium.org Review URL: https://codereview.chromium.org/668983002 Cr-Commit-Position: refs/heads/master@{#300903}
Diffstat (limited to 'chrome/browser/prefs/pref_service_syncable.h')
-rw-r--r--chrome/browser/prefs/pref_service_syncable.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/prefs/pref_service_syncable.h b/chrome/browser/prefs/pref_service_syncable.h
index fd799b3..c1b4960 100644
--- a/chrome/browser/prefs/pref_service_syncable.h
+++ b/chrome/browser/prefs/pref_service_syncable.h
@@ -44,7 +44,7 @@ class PrefServiceSyncable : public PrefService {
base::Callback<void(PersistentPrefStore::PrefReadError)>
read_error_callback,
bool async);
- virtual ~PrefServiceSyncable();
+ ~PrefServiceSyncable() override;
// Creates an incognito copy of the pref service that shares most pref stores
// but uses a fresh non-persistent overlay for the user pref store and an
@@ -79,7 +79,7 @@ class PrefServiceSyncable : public PrefService {
syncer::SyncableService* GetSyncableService(const syncer::ModelType& type);
// Do not call this after having derived an incognito or per tab pref service.
- virtual void UpdateCommandLinePrefStore(PrefStore* cmd_line_store) override;
+ void UpdateCommandLinePrefStore(PrefStore* cmd_line_store) override;
void AddSyncedPrefObserver(const std::string& name,
SyncedPrefObserver* observer);