diff options
| author | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-19 04:22:12 +0000 |
|---|---|---|
| committer | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-19 04:22:12 +0000 |
| commit | e90a01fb2a79f51878619f97e33362e24d727a9c (patch) | |
| tree | 72af2c75d8b798a822169266d3610511420c50e4 /chrome/browser/prefs/pref_service_syncable.h | |
| parent | 86ecceb0ddcf444366d16c0dee205dedcea04f96 (diff) | |
| download | chromium_src-e90a01fb2a79f51878619f97e33362e24d727a9c.zip chromium_src-e90a01fb2a79f51878619f97e33362e24d727a9c.tar.gz chromium_src-e90a01fb2a79f51878619f97e33362e24d727a9c.tar.bz2 | |
Clean up PrefServiceBuilder
* Use simple setters rather than With* methods.
* Explicitly transfer memory ownership.
* Rename "Builder" to "Factory"
* Eliminate the side-effect of resetting the builder from the Create* methods.
Along the way, fix a memory leak in the Android WebView.
BUG=315499
TEST=none (code should continue to compile and tests should continue to pass)
R=joi@chromium.org
Review URL: https://codereview.chromium.org/64193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235913 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/prefs/pref_service_syncable.h')
| -rw-r--r-- | chrome/browser/prefs/pref_service_syncable.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/prefs/pref_service_syncable.h b/chrome/browser/prefs/pref_service_syncable.h index b8390f1..1c23dd6 100644 --- a/chrome/browser/prefs/pref_service_syncable.h +++ b/chrome/browser/prefs/pref_service_syncable.h @@ -34,7 +34,7 @@ class PrefServiceSyncable : public PrefService { static PrefServiceSyncable* FromProfile(Profile* profile); static PrefServiceSyncable* IncognitoFromProfile(Profile* profile); - // You may wish to use PrefServiceBuilder or one of its subclasses + // You may wish to use PrefServiceFactory or one of its subclasses // for simplified construction. PrefServiceSyncable( PrefNotifierImpl* pref_notifier, |