diff options
author | dcheng <dcheng@chromium.org> | 2014-10-23 09:37:48 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-23 16:38:05 +0000 |
commit | 8f4b862cd59d29d615929c5c66ca3fe749914cd0 (patch) | |
tree | ed406e472b20e42dd5bdc819d812ee2a9435f8eb /chrome/browser/prefs/prefs_syncable_service_unittest.cc | |
parent | d28506ba1497a3f5fa5b9f6702892cb1cb58ea15 (diff) | |
download | chromium_src-8f4b862cd59d29d615929c5c66ca3fe749914cd0.zip chromium_src-8f4b862cd59d29d615929c5c66ca3fe749914cd0.tar.gz chromium_src-8f4b862cd59d29d615929c5c66ca3fe749914cd0.tar.bz2 |
Standardize usage of virtual/override/final in chrome/browser/prefs
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=gab@chromium.org
Review URL: https://codereview.chromium.org/668983002
Cr-Commit-Position: refs/heads/master@{#300903}
Diffstat (limited to 'chrome/browser/prefs/prefs_syncable_service_unittest.cc')
-rw-r--r-- | chrome/browser/prefs/prefs_syncable_service_unittest.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/chrome/browser/prefs/prefs_syncable_service_unittest.cc b/chrome/browser/prefs/prefs_syncable_service_unittest.cc index 2f20316..462c46d 100644 --- a/chrome/browser/prefs/prefs_syncable_service_unittest.cc +++ b/chrome/browser/prefs/prefs_syncable_service_unittest.cc @@ -40,7 +40,7 @@ class TestSyncProcessorStub : public syncer::SyncChangeProcessor { public: explicit TestSyncProcessorStub(syncer::SyncChangeList* output) : output_(output), fail_next_(false) {} - virtual syncer::SyncError ProcessSyncChanges( + syncer::SyncError ProcessSyncChanges( const tracked_objects::Location& from_here, const syncer::SyncChangeList& change_list) override { if (output_) @@ -58,8 +58,7 @@ class TestSyncProcessorStub : public syncer::SyncChangeProcessor { fail_next_ = true; } - virtual syncer::SyncDataList GetAllSyncData(syncer::ModelType type) - const override { + syncer::SyncDataList GetAllSyncData(syncer::ModelType type) const override { return syncer::SyncDataList(); } private: |