summaryrefslogtreecommitdiffstats
path: root/chrome/browser/prefs
diff options
context:
space:
mode:
authorestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-07-17 06:37:40 +0000
committerestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-07-17 06:37:40 +0000
commit012d1317d2983f3b821632e1008b53cfda135647 (patch)
tree9ee44e45bac7cd4d5cbf622544b43eef9f3be078 /chrome/browser/prefs
parent6e9bfe1e87c80238666d32878e18322e108d8700 (diff)
downloadchromium_src-012d1317d2983f3b821632e1008b53cfda135647.zip
chromium_src-012d1317d2983f3b821632e1008b53cfda135647.tar.gz
chromium_src-012d1317d2983f3b821632e1008b53cfda135647.tar.bz2
Eliminate CreateBooleanValue from test files
BUG=160586 Review URL: https://codereview.chromium.org/397793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283665 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/prefs')
-rw-r--r--chrome/browser/prefs/chrome_pref_service_unittest.cc4
-rw-r--r--chrome/browser/prefs/pref_hash_calculator_unittest.cc2
-rw-r--r--chrome/browser/prefs/pref_hash_filter_unittest.cc2
-rw-r--r--chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc4
4 files changed, 6 insertions, 6 deletions
diff --git a/chrome/browser/prefs/chrome_pref_service_unittest.cc b/chrome/browser/prefs/chrome_pref_service_unittest.cc
index 704dcf0..2940ce8 100644
--- a/chrome/browser/prefs/chrome_pref_service_unittest.cc
+++ b/chrome/browser/prefs/chrome_pref_service_unittest.cc
@@ -105,9 +105,9 @@ class ChromePrefServiceWebKitPrefs : public ChromeRenderViewHostTestHarness {
pref_services->SetUserPref(prefs::kWebKitDefaultFontSize,
base::Value::CreateIntegerValue(20));
pref_services->SetUserPref(prefs::kWebKitTextAreasAreResizable,
- base::Value::CreateBooleanValue(false));
+ new base::FundamentalValue(false));
pref_services->SetUserPref(prefs::kWebKitUsesUniversalDetector,
- base::Value::CreateBooleanValue(true));
+ new base::FundamentalValue(true));
pref_services->SetUserPref("webkit.webprefs.foo",
base::Value::CreateStringValue("bar"));
}
diff --git a/chrome/browser/prefs/pref_hash_calculator_unittest.cc b/chrome/browser/prefs/pref_hash_calculator_unittest.cc
index f8a44bd..356cc56 100644
--- a/chrome/browser/prefs/pref_hash_calculator_unittest.cc
+++ b/chrome/browser/prefs/pref_hash_calculator_unittest.cc
@@ -81,7 +81,7 @@ TEST(PrefHashCalculatorTest, CatchHashChanges) {
static const char kDeviceId[] = "test_device_id1";
scoped_ptr<base::Value> null_value(base::Value::CreateNullValue());
- scoped_ptr<base::Value> bool_value(base::Value::CreateBooleanValue(false));
+ scoped_ptr<base::Value> bool_value(new base::FundamentalValue(false));
scoped_ptr<base::Value> int_value(
base::Value::CreateIntegerValue(1234567890));
scoped_ptr<base::Value> double_value(
diff --git a/chrome/browser/prefs/pref_hash_filter_unittest.cc b/chrome/browser/prefs/pref_hash_filter_unittest.cc
index 287b838..cbf12b1 100644
--- a/chrome/browser/prefs/pref_hash_filter_unittest.cc
+++ b/chrome/browser/prefs/pref_hash_filter_unittest.cc
@@ -569,7 +569,7 @@ TEST_P(PrefHashFilterTest, MultiplePrefsFilterSerializeData) {
base::Value* int_value3 = base::Value::CreateIntegerValue(3);
base::Value* int_value4 = base::Value::CreateIntegerValue(4);
base::DictionaryValue* dict_value = new base::DictionaryValue;
- dict_value->Set("a", base::Value::CreateBooleanValue(true));
+ dict_value->Set("a", new base::FundamentalValue(true));
root_dict.Set(kAtomicPref, int_value1);
root_dict.Set(kAtomicPref2, int_value2);
root_dict.Set(kAtomicPref3, int_value3);
diff --git a/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc b/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
index 7980559..222429b 100644
--- a/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
+++ b/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
@@ -192,7 +192,7 @@ IN_PROC_BROWSER_TEST_F(SyncedPrefChangeRegistrarTest,
policies.Set(policy::key::kShowHomeButton,
policy::POLICY_LEVEL_MANDATORY,
policy::POLICY_SCOPE_USER,
- base::Value::CreateBooleanValue(true),
+ new base::FundamentalValue(true),
NULL);
UpdateChromePolicy(policies);
@@ -213,7 +213,7 @@ IN_PROC_BROWSER_TEST_F(SyncedPrefChangeRegistrarTest,
policies.Set(policy::key::kShowHomeButton,
policy::POLICY_LEVEL_MANDATORY,
policy::POLICY_SCOPE_USER,
- base::Value::CreateBooleanValue(true),
+ new base::FundamentalValue(true),
NULL);
UpdateChromePolicy(policies);