summaryrefslogtreecommitdiffstats
path: root/chrome/browser/prefs
diff options
context:
space:
mode:
authorlipalani@chromium.org <lipalani@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-20 20:12:28 +0000
committerlipalani@chromium.org <lipalani@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-20 20:12:28 +0000
commit5d36e05c6ca86090652af10f08881677ee25775d (patch)
tree207b2224d01b974d0556caed3e8384e2abd83378 /chrome/browser/prefs
parent6b5071c252b83d1bc4186fa3b503c0a1de95a109 (diff)
downloadchromium_src-5d36e05c6ca86090652af10f08881677ee25775d.zip
chromium_src-5d36e05c6ca86090652af10f08881677ee25775d.tar.gz
chromium_src-5d36e05c6ca86090652af10f08881677ee25775d.tar.bz2
Make the Datatypes using new syncapi upload unrecoverable errors to breakpad.
BUG= TEST= Review URL: http://codereview.chromium.org/10061002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133251 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/prefs')
-rw-r--r--chrome/browser/prefs/pref_model_associator.cc7
-rw-r--r--chrome/browser/prefs/pref_model_associator.h6
2 files changed, 11 insertions, 2 deletions
diff --git a/chrome/browser/prefs/pref_model_associator.cc b/chrome/browser/prefs/pref_model_associator.cc
index b70302a..16dc0c3 100644
--- a/chrome/browser/prefs/pref_model_associator.cc
+++ b/chrome/browser/prefs/pref_model_associator.cc
@@ -12,6 +12,7 @@
#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/sync/api/sync_change.h"
+#include "chrome/browser/sync/api/sync_error_factory.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/pref_names.h"
#include "sync/protocol/preference_specifics.pb.h"
@@ -107,13 +108,16 @@ void PrefModelAssociator::InitPrefAndAssociate(
SyncError PrefModelAssociator::MergeDataAndStartSyncing(
syncable::ModelType type,
const SyncDataList& initial_sync_data,
- scoped_ptr<SyncChangeProcessor> sync_processor) {
+ scoped_ptr<SyncChangeProcessor> sync_processor,
+ scoped_ptr<SyncErrorFactory> sync_error_factory) {
DCHECK_EQ(type, PREFERENCES);
DCHECK(CalledOnValidThread());
DCHECK(pref_service_);
DCHECK(!sync_processor_.get());
DCHECK(sync_processor.get());
+ DCHECK(sync_error_factory.get());
sync_processor_ = sync_processor.Pass();
+ sync_error_factory_ = sync_error_factory.Pass();
SyncChangeList new_changes;
std::set<std::string> remaining_preferences = registered_preferences_;
@@ -161,6 +165,7 @@ void PrefModelAssociator::StopSyncing(syncable::ModelType type) {
DCHECK_EQ(type, PREFERENCES);
models_associated_ = false;
sync_processor_.reset();
+ sync_error_factory_.reset();
}
Value* PrefModelAssociator::MergePreference(
diff --git a/chrome/browser/prefs/pref_model_associator.h b/chrome/browser/prefs/pref_model_associator.h
index de4b645..6d0bb52 100644
--- a/chrome/browser/prefs/pref_model_associator.h
+++ b/chrome/browser/prefs/pref_model_associator.h
@@ -43,7 +43,8 @@ class PrefModelAssociator
virtual SyncError MergeDataAndStartSyncing(
syncable::ModelType type,
const SyncDataList& initial_sync_data,
- scoped_ptr<SyncChangeProcessor> sync_processor) OVERRIDE;
+ scoped_ptr<SyncChangeProcessor> sync_processor,
+ scoped_ptr<SyncErrorFactory> sync_error_factory) OVERRIDE;
virtual void StopSyncing(syncable::ModelType type) OVERRIDE;
// Returns the list of preference names that are registered as syncable, and
@@ -143,6 +144,9 @@ class PrefModelAssociator
// Sync's SyncChange handler. We push all our changes through this.
scoped_ptr<SyncChangeProcessor> sync_processor_;
+ // Sync's error handler. We use this to create sync errors.
+ scoped_ptr<SyncErrorFactory> sync_error_factory_;
+
DISALLOW_COPY_AND_ASSIGN(PrefModelAssociator);
};