diff options
| author | fdoray@chromium.org <fdoray@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-21 03:58:58 +0000 |
|---|---|---|
| committer | fdoray@chromium.org <fdoray@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-21 03:58:58 +0000 |
| commit | 3427a9c9c714562fbc800a741e70244f1c767d2b (patch) | |
| tree | 7627117f5730d003b2ac8f6bcb1b1a001daecea7 /chrome/browser/process_singleton_modal_dialog_lock.h | |
| parent | e90b772e530dd8cbb7a99e979ac0176a0d0bcddb (diff) | |
| download | chromium_src-3427a9c9c714562fbc800a741e70244f1c767d2b.zip chromium_src-3427a9c9c714562fbc800a741e70244f1c767d2b.tar.gz chromium_src-3427a9c9c714562fbc800a741e70244f1c767d2b.tar.bz2 | |
Fix crash that occurs when page is reloaded while "Email confirmation" dialog is displayed.
When a navigation occurs in a tab that shows a tab modal confirm dialog,
the OnClosed() method of this dialog is invoked. No new navigation should
happen at this time. Otherwise, the 2 calls to WebContentsImpl::NavigateToPendingEntry
(1 for the navigation that closed the dialog and 1 for the navigation that
occured from the OnClosed() callback) are nested and a crash occurs.
StartExplicitSync() (one_click_signin_helper.cc) now checks whether a
navigation is in progress before making a redirection to the NTP/Apps
page. No redirection is made if a navigation is in progress.
TEST=
1.Launch chrome and sign in to chrome, go to settings and disconnect account
2click on sign into chrome, sign out and sign in as different user, sign in with different user id
3.Blank page with confirmation box will appear, bookmark this page and drag it from bookmarks bar to omnibox
Expected result: no crash
BUG=293261
Review URL: https://chromiumcodereview.appspot.com/23736010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224552 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/process_singleton_modal_dialog_lock.h')
0 files changed, 0 insertions, 0 deletions