Initial set of browser_tests for Protector and DefaultSearchProviderChange.

Some slight changes is Protector/BaseSettingChange: removed the OnBeforeRemoved callback (without calling any callback before the removal).

BUG=None
TEST=browser_tests:ProtectorTest.*,browser_tests:DefaultSearchProviderChange.*

Review URL: https://chromiumcodereview.appspot.com/9236001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118083 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 8 insertions, 6 deletions

diff --git a/chrome/browser/protector/protector.h b/chrome/browser/protector/protector.h
index 803a2af..3ded4a3 100644
--- a/chrome/browser/protector/protector.h
+++ b/chrome/browser/protector/protector.h
@@ -28,16 +28,16 @@ class Protector : public SettingsChangeGlobalErrorDelegate {
  public:
   explicit Protector(Profile* profile);
 
-  // Opens a tab with specified URL in the browser window we've shown error
-  // bubble for.
-  void OpenTab(const GURL& url);
-
   // Shows global error about the specified change. Owns |change|.
-  void ShowChange(BaseSettingChange* change);
+  virtual void ShowChange(BaseSettingChange* change);
 
   // Silently discards any change previously shown (without calling Discard),
   // removes global error and deletes itself.
-  void DismissChange();
+  virtual void DismissChange();
+
+  // Opens a tab with specified URL in the browser window we've shown error
+  // bubble for.
+  virtual void OpenTab(const GURL& url);
 
   // Returns the Profile instance we've shown error bubble for.
   Profile* profile() { return profile_; }
@@ -50,6 +50,8 @@ class Protector : public SettingsChangeGlobalErrorDelegate {
 
  private:
   friend class base::DeleteHelper<Protector>;
+  friend class MockProtector;
+  friend class ProtectorTest;
 
   // The object can only be allocated and destroyed on heap.
   virtual ~Protector();